Password bubble: Introduce a command to open the bubble.

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 0c3f0e03892b268c66955b69bbdc2f91b23b30aa..aef7187ce1115d609f4f5324ea921846882e13c8 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -10,6 +10,7 @@
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
+#include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 #include "chrome/browser/ui/views/passwords/manage_password_item_view.h"
@@ -74,6 +75,22 @@ class SavePasswordRefusalComboboxModel : public ui::ComboboxModel {
 
 }  // namespace
 

[Peter Kasting, 2014/04/25 22:12:02]

Nit: One more newline here, and above the "ManagePasswordsBubbleView" divider
below

[Mike West, 2014/04/28 10:52:56]

Done.

[Peter Kasting, 2014/04/28 20:07:14]

Doesn't look like this actually happened.

+// browser_dialog -------------------------------------------------------------

[vabr (Chromium), 2014/04/25 15:26:17]

nit: This is not entirely clear to me -- it does not look like a class name, and
no similarly named variables are in sight. Please elaborate.

[Peter Kasting, 2014/04/25 22:12:02]

I'd probably call the divider "Globals" instead.

[Mike West, 2014/04/28 10:52:56]

Done.

+
+namespace chrome {
+
+void ShowManagePasswordsBubble(content::WebContents* web_contents) {
+    ManagePasswordsBubbleUIController* controller =

[Peter Kasting, 2014/04/25 22:12:02]

Nit: Whole function should be indented 2, not 4

[Mike West, 2014/04/28 10:52:56]

Done.

+        ManagePasswordsBubbleUIController::FromWebContents(web_contents);
+    bool is_automatic_display =
+        controller->manage_passwords_bubble_needs_showing();
+    ManagePasswordsBubbleView::ShowBubble(
+        web_contents,
+        is_automatic_display ? ManagePasswordsBubbleView::AUTOMATIC
+                             : ManagePasswordsBubbleView::USER_ACTION);

[Peter Kasting, 2014/04/25 22:12:02]

Nit: Wrap/indent like:

  ManagePasswordsBubbleView::ShowBubble(
      web_contents,
      is_automatic_display ?
          ManagePasswordsBubbleView::AUTOMATIC :
          ManagePasswordsBubbleView::USER_ACTION);

This will also allow you to inline
"controller->manage_passwords_bubble_needs_showing()" into this and eliminate
the temp, without causing awkward wrapping issues.

[Mike West, 2014/04/28 10:52:56]

Done.

[Peter Kasting, 2014/04/28 20:07:14]

The wrapping is still wrong here.  Operators go on the ends of lines, not their
start.

+}
+
+}  // namespace chrome
 
 // ManagePasswordsBubbleView --------------------------------------------------