Password bubble: Introduce a command to open the bubble.

chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/passwords/manage_passwords_view_test.h"
+
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_command_controller.h"
+#include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller_mock.h"
+#include "chrome/browser/ui/passwords/manage_passwords_icon.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
+#include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
+#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/interactive_test_utils.h"
+#include "components/autofill/core/common/password_form.h"
+#include "components/password_manager/core/browser/mock_password_manager_driver.h"
+#include "components/password_manager/core/browser/password_form_manager.h"
+#include "components/password_manager/core/browser/password_manager_driver.h"
+#include "components/password_manager/core/browser/password_manager_metrics_util.h"
+#include "components/password_manager/core/browser/stub_password_manager_client.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+void ManagePasswordsViewTest::SetUpOnMainThread() {
+  // Create the test UIController here so that it's bound to the currently
+  // active WebContents.
+  new ManagePasswordsBubbleUIControllerMock(
+      browser()->tab_strip_model()->GetActiveWebContents());
+}
+
+ManagePasswordsBubbleUIControllerMock*
+    ManagePasswordsViewTest::controller() {
+  return static_cast<ManagePasswordsBubbleUIControllerMock*>(
+      ManagePasswordsBubbleUIController::FromWebContents(
+          browser()->tab_strip_model()->GetActiveWebContents()));
+}
+
+ManagePasswordsIconView* ManagePasswordsViewTest::view() const {
+  BrowserView* browser_view = reinterpret_cast<BrowserView*>(

[vabr (Chromium), 2014/04/25 15:26:17]

nit: This is casting a class to its subclass, and on the assumption that
window() actually is an instance of BrowserView, not reinterpreting the pointer.
By the same argument I used last time for casting the UIController, this should
be a static_cast.

[Peter Kasting, 2014/04/25 22:12:02]

Indeed, a cast between different points of an inheritance hierarchy must be a
static_cast so the pointer is adjusted properly if necessary; a reinterpret_cast
will do the wrong thing depending on your inheritance setup (e.g. with virtual
inheritance).

It probably "happens to work" here, but please fix.

[Mike West, 2014/04/28 10:52:56]

Done.

+      browser()->window());
+  return browser_view->GetToolbarView()
+                     ->location_bar()

[Peter Kasting, 2014/04/25 22:12:02]

Nit: Can go on previous line.

Also, put operators on ends of lines.

[Mike West, 2014/04/28 10:52:56]

Done.

+                     ->manage_passwords_icon_view();
+}
+
+void ManagePasswordsViewTest::ExecuteManagePasswordsCommand(
+    Expectation expectation) {
+  CommandUpdater* updater =
+      browser()->command_controller()->command_updater();
+  EXPECT_EQ(expectation == EXPECT_SUCCESS,
+            updater->IsCommandEnabled(IDC_MANAGE_PASSWORDS_FOR_PAGE));
+  EXPECT_EQ(expectation == EXPECT_SUCCESS,
+            updater->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE));
+}
+
+void ManagePasswordsViewTest::SetupManagingPasswords() {
+  base::string16 kTestUsername = base::ASCIIToUTF16("test_username");
+  autofill::PasswordFormMap map;
+  map[kTestUsername] = &test_form();
+  controller()->OnPasswordAutofilled(map);
+  controller()->UpdateIconAndBubbleState(view());
+}
+
+void ManagePasswordsViewTest::SetupPendingPassword() {
+  password_manager::StubPasswordManagerClient client;
+  password_manager::MockPasswordManagerDriver driver;
+  password_manager::PasswordFormManager* test_form_manager =

[Peter Kasting, 2014/04/25 22:12:02]

If the call below takes ownership of this (not 100% clear from the class
comments... consider clarifying), prefer to make this local a scoped_ptr and
then call release() below.  This makes it clear you're intentionally
transferring ownership.  (In theory, it's more exception-safe too -- if we used
exceptions.)

+      new password_manager::PasswordFormManager(
+          NULL, &client, &driver, test_form_, false);
+  controller()->OnPasswordSubmitted(test_form_manager);
+  controller()->UpdateIconAndBubbleState(view());
+}