Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view.h

Issue 246393004: Password bubble: Introduce a command to open the bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Test. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_ICON_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_ICON_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_ICON_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_ICON_VIEW_H_
7 7
8 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h" 8 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
9 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" 9 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
10 #include "ui/views/controls/image_view.h" 10 #include "ui/views/controls/image_view.h"
11 11
12 class CommandUpdater;
12 class ManagePasswordsBubbleUIController; 13 class ManagePasswordsBubbleUIController;
13 14
14 // View for the password icon in the Omnibox. 15 // View for the password icon in the Omnibox.
15 class ManagePasswordsIconView : public views::ImageView { 16 class ManagePasswordsIconView : public views::ImageView {
16 public: 17 public:
17 // Clicking on the ManagePasswordsIconView shows a ManagePasswordsBubbleView, 18 // Clicking on the ManagePasswordsIconView shows a ManagePasswordsBubbleView,
18 // which requires the current WebContents. Because the current WebContents 19 // which requires the current WebContents. Because the current WebContents
19 // changes as the user switches tabs, it cannot be provided in the 20 // changes as the user switches tabs, it cannot be provided in the
20 // constructor. Instead, a LocationBarView::Delegate is passed here so that it 21 // constructor. Instead, a LocationBarView::Delegate is passed here so that it
21 // can be queried for the current WebContents as needed. 22 // can be queried for the current WebContents as needed.
22 explicit ManagePasswordsIconView( 23 ManagePasswordsIconView(LocationBarView::Delegate* location_bar_delegate,
23 LocationBarView::Delegate* location_bar_delegate); 24 CommandUpdater* command_updater);
24 virtual ~ManagePasswordsIconView(); 25 virtual ~ManagePasswordsIconView();
25 26
26 // Updates the image and its tooltip appropriately, hiding or showing the icon 27 // Updates the image and its tooltip appropriately, hiding or showing the icon
27 // as needed. 28 // as needed.
28 void Update( 29 void Update(
29 ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller); 30 ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller);
30 31
31 // Shows a bubble from the icon if a password form was submitted. 32 // Shows a bubble from the icon if a password form was submitted.
33 //
34 // TODO(mkwst): This really, really, really shouldn't be part of the icon.
35 // Move the functionality to an appropriate controller (perhaps
36 // ManagePasswordsBubbleUIController, or whatever we end up renaming it to as
37 // part of http://crbug.com/365678).
32 void ShowBubbleIfNeeded( 38 void ShowBubbleIfNeeded(
33 ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller); 39 ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller);
34 40
35 void SetTooltip(bool password_to_be_saved); 41 void SetTooltip(bool password_to_be_saved);
36 42
37 private: 43 private:
44 // TODO(mkwst): Throw all of this away once we migrate to BubbleIconView as
45 // part of http://crbug.com/365678.
46 //
38 // views::ImageView: 47 // views::ImageView:
39 virtual bool GetTooltipText(const gfx::Point& p, 48 virtual bool GetTooltipText(const gfx::Point& p,
40 base::string16* tooltip) const OVERRIDE; 49 base::string16* tooltip) const OVERRIDE;
41 virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE; 50 virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
42 virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE; 51 virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
43 virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE; 52 virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
44 53
45 // The delegate used to get the currently visible WebContents. 54 // The delegate used to get the currently visible WebContents.
46 LocationBarView::Delegate* location_bar_delegate_; 55 LocationBarView::Delegate* location_bar_delegate_;
47 56
57 // The updater used to deliver commands to the browser; we'll use this to
58 // pop open the bubble when necessary.
59 CommandUpdater* command_updater_;
60
48 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsIconView); 61 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsIconView);
49 }; 62 };
50 63
51 #endif // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_ICON_VIEW_H_ 64 #endif // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_ICON_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698