Password bubble: Introduce a command to open the bubble.

chrome/browser/ui/browser_window.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/browser_close_manager.h"
 #include "chrome/browser/translate/translate_tab_helper.h"
@@ skipping 217 matching lines @@
 
   // Shows the bookmark prompt.
   // TODO(yosin): Make ShowBookmarkPrompt pure virtual.
   virtual void ShowBookmarkPrompt() {}
 
   // Shows the translate bubble.
   virtual void ShowTranslateBubble(content::WebContents* contents,
                                    translate::TranslateStep step,
                                    TranslateErrors::Type error_type) = 0;
 
+  // Shows the manage passwords bubble.
+  virtual void ShowManagePasswordsBubble(content::WebContents* contents) = 0;

[sky, 2014/04/23 17:14:04]

Do you really need this on BrowserWindow? The views implementation at least
doesn't seem to need anything from Browser/BrowserView to service this. In other
words, could this be a standalone function in browser_dialogs?

[Mike West, 2014/04/23 17:35:21]

I was following the Translate and Bookmark examples; that seemed to be the way
this sort of thing is done. If you'd prefer that I move the method off the
Window and into browser_dialogs, I'm happy to do so, but this seems more
consistent with existing code.

There's certainly no dependency on Browser to make this work, and I wouldn't
anticipate an eventual Cocoa implementation adding such a dependency.

+
 #if defined(ENABLE_ONE_CLICK_SIGNIN)
   enum OneClickSigninBubbleType {
     ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE,
     ONE_CLICK_SIGNIN_BUBBLE_TYPE_MODAL_DIALOG,
     ONE_CLICK_SIGNIN_BUBBLE_TYPE_SAML_MODAL_DIALOG
   };
 
   // Callback type used with the ShowOneClickSigninBubble() method.  If the
   // user chooses to accept the sign in, the callback is called to start the
   // sync process.
@@ skipping 189 matching lines @@
 
   // Returns the ToolbarView.
   virtual ToolbarView* GetToolbarView() const = 0;
 #endif
 
  protected:
   virtual ~BrowserWindowTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_