Password bubble: Introduce a command to open the bubble.

chrome/browser/ui/browser_dialogs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
 
 #include "base/callback.h"
 #include "chrome/browser/profiles/profile_window.h"
 #include "content/public/common/signed_certificate_timestamp_id_and_status.h"
@@ skipping 55 matching lines @@
 
 // Shows or hide the hung renderer dialog for the given WebContents.
 // We need to pass the WebContents to the dialog, because multiple tabs can hang
 // and it needs to keep track of which tabs are currently hung.
 void ShowHungRendererDialog(content::WebContents* contents);
 void HideHungRendererDialog(content::WebContents* contents);
 
 // Shows the Task Manager. |browser| can be NULL when called from Ash.
 void ShowTaskManager(Browser* browser);
 
-#if !defined(OS_MACOSX)
-// Shows the create web app shortcut dialog box.
-void ShowCreateWebAppShortcutsDialog(gfx::NativeWindow parent_window,
-                                     content::WebContents* web_contents);
-#endif
-
 // Shows the create chrome app shortcut dialog box.
 // On Mac, this creates a shortcut without prompting.
 // |close_callback| may be null.
 void ShowCreateChromeAppShortcutsDialog(gfx::NativeWindow parent_window,
                                         Profile* profile,
                                         const extensions::Extension* app,
                                         const base::Closure& close_callback);
 
 // Shows a color chooser that reports to the given WebContents.
 content::ColorChooser* ShowColorChooser(content::WebContents* web_contents,
@@ skipping 15 matching lines @@
 
 // Hides the User Manager.
 void HideUserManager();
 
 // Shows the Signed Certificate Timestamps viewer, to view the signed
 // certificate timestamps in |sct_ids_list|
 void ShowSignedCertificateTimestampsViewer(
     content::WebContents* web_contents,
     const content::SignedCertificateTimestampIDStatusList& sct_ids_list);
 
+#if !defined(OS_MACOSX)
+// Shows the create web app shortcut dialog box.
+void ShowCreateWebAppShortcutsDialog(gfx::NativeWindow parent_window,
+                                     content::WebContents* web_contents);

[Peter Kasting, 2014/04/28 20:07:15]

Nit: Don't move this block down here just to share the #if.  The first function
here makes sense where it was, next to ShowCreateChromeAppShortcutsDialog(), and
the views implementation of these functions is also in the old order.

If you're desperate to avoid having two #ifs, you could in theory add your new
function _above_ ShowCreateWebAppShortcutsDialog(), with both in the middle of
the file.

[Mike West, 2014/04/29 06:47:18]

Done.

+
+// Shows the ManagePasswords bubble for a particular |web_contents|.
+//
+// TODO(mkwst): Implement this feature on Mac: http://crbug.com/261628
+void ShowManagePasswordsBubble(content::WebContents* web_contents);
+#endif
+
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_