Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 246393002: Adding the ability to click on the images in the history and have that load (Closed)

Created:
6 years, 8 months ago by jcgregorio
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@history
Visibility:
Public.

Description

Adding the ability to click on the images in the history and have that load the code and image back into the editor space. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14310

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : remove old logging code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -39 lines) Patch
M experimental/webtry/js/run.js View 1 2 3 4 chunks +58 lines, -22 lines 0 comments Download
M experimental/webtry/templates/index.html View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/workspace.html View 2 chunks +5 lines, -7 lines 0 comments Download
M experimental/webtry/webtry.go View 1 2 9 chunks +55 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jcgregorio
6 years, 8 months ago (2014-04-22 02:27:21 UTC) #1
mtklein
https://codereview.chromium.org/246393002/diff/30001/experimental/webtry/js/run.js File experimental/webtry/js/run.js (right): https://codereview.chromium.org/246393002/diff/30001/experimental/webtry/js/run.js#newcode91 experimental/webtry/js/run.js:91: // The response is JSON of the form: I ...
6 years, 8 months ago (2014-04-22 17:24:17 UTC) #2
jcgregorio
https://codereview.chromium.org/246393002/diff/30001/experimental/webtry/js/run.js File experimental/webtry/js/run.js (right): https://codereview.chromium.org/246393002/diff/30001/experimental/webtry/js/run.js#newcode97 experimental/webtry/js/run.js:97: console.log(e.target.response); On 2014/04/22 17:24:18, mtklein wrote: > Intentionally leaving ...
6 years, 8 months ago (2014-04-22 18:02:08 UTC) #3
mtklein
On 2014/04/22 18:02:08, jcgregorio wrote: > https://codereview.chromium.org/246393002/diff/30001/experimental/webtry/js/run.js > File experimental/webtry/js/run.js (right): > > https://codereview.chromium.org/246393002/diff/30001/experimental/webtry/js/run.js#newcode97 > ...
6 years, 8 months ago (2014-04-22 18:16:50 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-22 18:18:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/246393002/50001
6 years, 8 months ago (2014-04-22 18:18:42 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 19:32:09 UTC) #7
Message was sent while issue was closed.
Change committed as 14310

Powered by Google App Engine
This is Rietveld 408576698