Don't use IsolateData for the exit hook as multiple embedders share the dart/bin while using differ…

Don't use IsolateData for the exit hook as multiple embedders share the dart/bin while using different isolate data structures.

Issue flutter/flutter#6506

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/4d65db8a959b5efeedc77682a21da1b646ae383f

[rmacnak, 2016-10-31 19:14:50]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-10-31 21:52:20]

lgtm

https://codereview.chromium.org/2463923002/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2463923002/diff/1/runtime/bin/main.cc#newcode...
runtime/bin/main.cc:1538: static void SnapshotOnExitHook(int64_t exit_code) {
As discussed offline maybe add a check here that this is called on the main
isolate?

[rmacnak, 2016-10-31 22:38:48]

https://codereview.chromium.org/2463923002/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2463923002/diff/1/runtime/bin/main.cc#newcode...
runtime/bin/main.cc:1538: static void SnapshotOnExitHook(int64_t exit_code) {
On 2016/10/31 21:52:20, siva wrote:
> As discussed offline maybe add a check here that this is called on the main
> isolate?

Done.

[rmacnak, 2016-10-31 22:56:29]

Description was changed from

==========
Don't use IsolateData for the exit hook as multiple embedders share the dart/bin
while using different isolate data structures.

Issue flutter/flutter#6506
==========

to

==========
Don't use IsolateData for the exit hook as multiple embedders share the dart/bin
while using different isolate data structures.

Issue flutter/flutter#6506

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4d65db8a959b5efeedc77682a21da1b646ae383f
==========

[rmacnak, 2016-10-31 22:56:30]

Committed patchset #2 (id:20001) manually as
4d65db8a959b5efeedc77682a21da1b646ae383f (presubmit successful).