Fix gn check for headless release static config

Fix gn check for headless release static config

BUG=659512
Committed: https://crrev.com/a0b55895c5825ff8c8d0c363357a1e45c374b814
Cr-Commit-Position: refs/heads/master@{#430633}

[perezju, 2016-10-31 17:03:48]

perezju@chromium.org changed reviewers:
+ alexclarke@chromium.org, phajdan.jr@chromium.org, skyostil@chromium.org

[Sami, 2016-10-31 18:54:22]

lgtm, thanks!

[perezju, 2016-11-01 13:30:50]

perezju@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-11-01 16:47:52]

It is unusual to have a release component build on the waterfall (normally we
have debug component and release static).

Does it make sense to leave this as static and set up an additional debug
component builder?

[perezju, 2016-11-02 09:05:33]

On 2016/11/01 16:47:52, Dirk Pranke wrote:
> It is unusual to have a release component build on the waterfall (normally we
> have debug component and release static).
> 
> Does it make sense to leave this as static and set up an additional debug
> component builder?

The issue is that the "release static" config is not working for headless (see
attached bug), so maybe the better solution would be to figure out why and fix
that? Could you give us any pointers?

[Dirk Pranke, 2016-11-02 22:25:47]

On 2016/11/02 09:05:33, perezju wrote:
> The issue is that the "release static" config is not working for headless (see
> attached bug), so maybe the better solution would be to figure out why and fix
> that? Could you give us any pointers?

Yes, it would be better to fix the underlying problem. I'll comment on the bug.

[perezju, 2016-11-03 10:18:08]

Description was changed from

==========
Fix gn config for linux_chromium_headless_rel

BUG=659512
==========

to

==========
Fix gn check for headless release static config

BUG=659512
==========

[perezju, 2016-11-03 10:18:33]

Awesome, thanks a lot for the help Dirk! PTAL.

[perezju, 2016-11-07 13:18:52]

On 2016/11/03 10:18:33, perezju wrote:
> Awesome, thanks a lot for the help Dirk! PTAL.

Ping.

Dirk, can you have a look? Thanks!

[Dirk Pranke, 2016-11-07 18:19:08]

lgtm, though I'm not an owner for these files ...

[Paweł Hajdan Jr., 2016-11-08 07:41:37]

LGTM

[perezju, 2016-11-08 15:37:43]

Thanks all!

[perezju, 2016-11-08 15:37:46]

The CQ bit was checked by perezju@chromium.org

[perezju, 2016-11-08 15:37:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2463863002/#ps20001
(title: "proper fix")

[commit-bot: I haz the power, 2016-11-08 15:38:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 16:43:03]

Description was changed from

==========
Fix gn check for headless release static config

BUG=659512
==========

to

==========
Fix gn check for headless release static config

BUG=659512
==========

[commit-bot: I haz the power, 2016-11-08 16:43:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 16:45:51]

Description was changed from

==========
Fix gn check for headless release static config

BUG=659512
==========

to

==========
Fix gn check for headless release static config

BUG=659512

Committed: https://crrev.com/a0b55895c5825ff8c8d0c363357a1e45c374b814
Cr-Commit-Position: refs/heads/master@{#430633}
==========

[commit-bot: I haz the power, 2016-11-08 16:45:52]

Patchset 2 (id:??) landed as
https://crrev.com/a0b55895c5825ff8c8d0c363357a1e45c374b814
Cr-Commit-Position: refs/heads/master@{#430633}