Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2463823003: Runs most aura tests with both backends (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Runs most aura tests with both backends I'm not updating the gesture detection ones as we may end up doing gestures slightly differently for mus. BUG=659155 TEST=none R=msw@chromium.org Committed: https://crrev.com/9f40769bf7e456056779a47daac54d764ea2d710 Cr-Commit-Position: refs/heads/master@{#428836}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : WindowEventDispatcherTestWithMessageLoop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -137 lines) Patch
M ui/aura/test/aura_test_base.h View 3 chunks +22 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 2 51 chunks +66 lines, -51 lines 0 comments Download
M ui/aura/window_targeter_unittest.cc View 8 chunks +13 lines, -14 lines 0 comments Download
M ui/aura/window_unittest.cc View 71 chunks +82 lines, -72 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
4 years, 1 month ago (2016-10-31 16:53:30 UTC) #1
msw
lgtm with a comment https://codereview.chromium.org/2463823003/diff/1/ui/aura/window_event_dispatcher_unittest.cc File ui/aura/window_event_dispatcher_unittest.cc (right): https://codereview.chromium.org/2463823003/diff/1/ui/aura/window_event_dispatcher_unittest.cc#newcode2065 ui/aura/window_event_dispatcher_unittest.cc:2065: TEST_P(WindowEventDispatcherTestWithMessageLoop, EventRepostedInNonNestedLoop) { I think ...
4 years, 1 month ago (2016-10-31 18:05:30 UTC) #2
sky
https://codereview.chromium.org/2463823003/diff/1/ui/aura/window_event_dispatcher_unittest.cc File ui/aura/window_event_dispatcher_unittest.cc (right): https://codereview.chromium.org/2463823003/diff/1/ui/aura/window_event_dispatcher_unittest.cc#newcode2065 ui/aura/window_event_dispatcher_unittest.cc:2065: TEST_P(WindowEventDispatcherTestWithMessageLoop, EventRepostedInNonNestedLoop) { On 2016/10/31 18:05:30, msw wrote: > ...
4 years, 1 month ago (2016-10-31 20:49:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463823003/40001
4 years, 1 month ago (2016-10-31 20:50:25 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-31 22:15:05 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 22:17:55 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9f40769bf7e456056779a47daac54d764ea2d710
Cr-Commit-Position: refs/heads/master@{#428836}

Powered by Google App Engine
This is Rietveld 408576698