Add virtual tests for XHR with mojo-loading

Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360
Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Committed: https://crrev.com/a474c91a2696cbb9cd57b6462e2252e7db6afd78
Cr-Original-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Original-Commit-Position: refs/heads/master@{#430874}
Cr-Commit-Position: refs/heads/master@{#431191}

[yhirano, 2016-10-31 10:36:36]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 10:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-10-31 10:38:28]

yhirano@chromium.org changed reviewers:
+ tzik@chromium.org

[commit-bot: I haz the power, 2016-10-31 11:18:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 11:18:31]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yhirano, 2016-10-31 11:52:03]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 11:52:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 13:47:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 13:47:46]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-11-02 08:10:07]

lgtm

[yhirano, 2016-11-04 02:01:22]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 02:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 02:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:13:22]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yhirano, 2016-11-04 02:23:59]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 02:24:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 04:00:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:00:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhirano, 2016-11-04 04:01:04]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 04:01:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-04 05:39:59]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2016-11-04 05:39:59]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-11-04 05:39:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2463753002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-11-04 05:40:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:04:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-04 06:07:18]

Description was changed from

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917
==========

to

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}
==========

[commit-bot: I haz the power, 2016-11-04 06:07:20]

Patchset 3 (id:??) landed as
https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}

[Mike West, 2016-11-04 11:17:20]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2477673004/ by mkwst@chromium.org.

The reason for reverting is: This patch revealed some ASAN and MSAN failures:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precis...
and
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precis....

Reverting for now, please take a look..

[yhirano, 2016-11-07 01:22:27]

Description was changed from

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}
==========

to

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}
==========

[yhirano, 2016-11-07 01:44:19]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 01:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-07 02:10:57]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 02:11:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 03:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 03:27:39]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-07 03:51:56]

reopen

[yhirano, 2016-11-07 03:53:57]

Description was changed from

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}
==========

to

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}
==========

[yhirano, 2016-11-07 03:54:55]

yhirano@chromium.org changed reviewers:
+ nasko@chromium.org

[yhirano, 2016-11-07 03:54:56]

The content change fixes ASAN failures.

+nasko@ for the content change.

[nasko, 2016-11-08 01:12:12]

https://codereview.chromium.org/2463753002/diff/80001/content/child/url_respo...
File content/child/url_response_body_consumer.cc (right):

https://codereview.chromium.org/2463753002/diff/80001/content/child/url_respo...
content/child/url_response_body_consumer.cc:91:
scoped_refptr<URLResponseBodyConsumer> protect(this);
What causes the OnReceivedData to ref-count down this object? Is it a failure
condition? Is this code safe in face of such condition?

[yhirano, 2016-11-08 01:34:45]

https://codereview.chromium.org/2463753002/diff/80001/content/child/url_respo...
File content/child/url_response_body_consumer.cc (right):

https://codereview.chromium.org/2463753002/diff/80001/content/child/url_respo...
content/child/url_response_body_consumer.cc:91:
scoped_refptr<URLResponseBodyConsumer> protect(this);
On 2016/11/08 01:12:12, nasko wrote:
> What causes the OnReceivedData to ref-count down this object? Is it a failure
> condition? Is this code safe in face of such condition?

RequestPeer::OnReceivedData may cancel the request. The cancel operation 

 1. calls URLResponseBodyConsumer::Cancel, and
 2. dereferences the URLResponseBodyConsumer.

Without this scoped_refptr, |this| URLResponseBodyConsumer will be destructed at
that time. With this scoped_refptr, this function will return because
has_been_cancelled_ will be set when URLResponseBodyConsumer::Cancel is called.

[nasko, 2016-11-08 16:32:15]

content/ LGTM

https://codereview.chromium.org/2463753002/diff/80001/content/child/url_respo...
File content/child/url_response_body_consumer.cc (right):

https://codereview.chromium.org/2463753002/diff/80001/content/child/url_respo...
content/child/url_response_body_consumer.cc:91:
scoped_refptr<URLResponseBodyConsumer> protect(this);
On 2016/11/08 01:34:45, yhirano wrote:
> On 2016/11/08 01:12:12, nasko wrote:
> > What causes the OnReceivedData to ref-count down this object? Is it a
failure
> > condition? Is this code safe in face of such condition?
> 
> RequestPeer::OnReceivedData may cancel the request. The cancel operation 
> 
>  1. calls URLResponseBodyConsumer::Cancel, and
>  2. dereferences the URLResponseBodyConsumer.
> 
> Without this scoped_refptr, |this| URLResponseBodyConsumer will be destructed
at
> that time. With this scoped_refptr, this function will return because
> has_been_cancelled_ will be set when URLResponseBodyConsumer::Cancel is
called.

I was missing the bit about has_been_cancelled_ being set to true in the
::Cancel method. Thanks for the details!

[yhirano, 2016-11-09 01:11:53]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-11-09 01:11:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2463753002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-11-09 01:12:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-09 02:21:34]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 02:21:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-09 02:24:12]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 02:24:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-09 02:27:39]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 02:28:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-09 03:53:01]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 03:53:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-09 05:17:36]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2016-11-09 05:17:37]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-11-09 05:17:38]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org,
tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2463753002/#ps160001
(title: "fix")

[commit-bot: I haz the power, 2016-11-09 05:17:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 05:42:10]

Description was changed from

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}
==========

to

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}
==========

[commit-bot: I haz the power, 2016-11-09 05:42:11]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-11-09 05:45:20]

Description was changed from

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Cr-Commit-Position: refs/heads/master@{#429808}
==========

to

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Cr-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Commit-Position: refs/heads/master@{#430874}
==========

[commit-bot: I haz the power, 2016-11-09 05:45:21]

Patchset 9 (id:??) landed as
https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Cr-Commit-Position: refs/heads/master@{#430874}

[Łukasz Anforowicz, 2016-11-09 17:54:09]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2493503002/ by lukasza@chromium.org.

The reason for reverting is: The new tests fail when OOPIFs (out of process
iframes / aka remote frames) are possible and turn the Site Isolation Win bot
red.  Most likely failure modes differ between --site-per-process mode and the
expectations landed in this CL in
third_party/WebKit/LayoutTests/TestExpectations (so maybe the experimental
feature needs to also maintain a separate set of test expectations in
third_party/WebKit/LayoutTests/FlagExpectations/site-per-process).

Example red build:
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/bui...
.

[yhirano, 2016-11-10 01:47:17]

Description was changed from

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Cr-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Commit-Position: refs/heads/master@{#430874}
==========

to

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Cr-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Commit-Position: refs/heads/master@{#430874}
==========

[yhirano, 2016-11-10 01:47:30]

reopening again...

[yhirano, 2016-11-10 03:51:13]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 03:51:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-10 03:52:07]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2016-11-10 03:53:23]

Patchset #10 (id:180001) has been deleted

[yhirano, 2016-11-10 04:00:29]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 04:00:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-10 04:03:29]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2016-11-10 04:52:14]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-11-10 04:52:14]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org,
tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2463753002/#ps200001
(title: "fix")

[commit-bot: I haz the power, 2016-11-10 04:52:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-10 05:52:18]

Landing with FlagExpectations/site-per-process.

[commit-bot: I haz the power, 2016-11-10 05:58:34]

Description was changed from

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Cr-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Commit-Position: refs/heads/master@{#430874}
==========

to

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Cr-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Commit-Position: refs/heads/master@{#430874}
==========

[commit-bot: I haz the power, 2016-11-10 05:58:36]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-11-10 06:00:22]

Description was changed from

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Cr-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Commit-Position: refs/heads/master@{#430874}
==========

to

==========
Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG=659917, 662360

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Committed: https://crrev.com/a474c91a2696cbb9cd57b6462e2252e7db6afd78
Cr-Original-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Original-Commit-Position: refs/heads/master@{#430874}
Cr-Commit-Position: refs/heads/master@{#431191}
==========

[commit-bot: I haz the power, 2016-11-10 06:00:24]

Patchset 10 (id:??) landed as
https://crrev.com/a474c91a2696cbb9cd57b6462e2252e7db6afd78
Cr-Commit-Position: refs/heads/master@{#431191}