Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2463743003: Import web-platform-tests manual tests by default (Closed)
Patch Set: update deps_updater_unittest.py Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
index 5d9813ef2d28cde0bb422eb3d29f5d7b3924ddde..ab655cbe06a620e5ce9ac79b9bf39522513411b5 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
@@ -193,11 +193,6 @@ class DepsUpdater(object):
self.run(['git', 'add', '--all', 'LayoutTests/imported/%s' % dest_dir_name])
- self.print_('## Deleting manual tests.')
- files_to_delete = self.fs.files_under(dest_path, file_filter=self.is_manual_test)
- for subpath in files_to_delete:
- self.remove('LayoutTests', 'imported', subpath)
-
self.print_('## Deleting any orphaned baselines.')
previous_baselines = self.fs.files_under(dest_path, file_filter=self.is_baseline)
for subpath in previous_baselines:
@@ -236,21 +231,6 @@ class DepsUpdater(object):
self.print_('## Done: no changes to import.')
return False
- def is_manual_test(self, fs, dirname, basename):
- """Returns True if the file should be removed because it's a manual test.
-
- Tests with "-manual" in the name are not considered manual tests
- if there is a corresponding JS automation file.
- """
- basename_without_extension, _ = self.fs.splitext(basename)
- if not basename_without_extension.endswith('-manual'):
- return False
- dir_from_wpt = fs.relpath(dirname, self.path_from_webkit_base('LayoutTests', 'imported', 'wpt'))
- automation_dir = self.path_from_webkit_base('LayoutTests', 'imported', 'wpt_automation', dir_from_wpt)
- if fs.isfile(fs.join(automation_dir, '%s-automation.js' % basename_without_extension)):
- return False
- return True
-
# Callback for FileSystem.files_under; not all arguments used - pylint: disable=unused-argument
def is_baseline(self, fs, dirname, basename):
return basename.endswith('-expected.txt')

Powered by Google App Engine
This is Rietveld 408576698