Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2463743002: [wasm] Use correct parameter type in wasm-run-utils.h (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use correct parameter type in wasm-run-utils.h Due to a typo wasm-run-utils used the type of the first parameter for all parameters. This caused problems if not all parameters had the same type. R=titzer@chromium.org, clemensh@chromium.org Committed: https://crrev.com/c4119758d89ebd588eda9838383600912ee398ce Cr-Commit-Position: refs/heads/master@{#40667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 1 month ago (2016-10-31 10:12:08 UTC) #1
titzer
On 2016/10/31 10:12:08, ahaas wrote: lgtm. Surprised that's been in there so long!
4 years, 1 month ago (2016-10-31 10:22:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463743002/1
4 years, 1 month ago (2016-10-31 10:49:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 10:51:20 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:17:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4119758d89ebd588eda9838383600912ee398ce
Cr-Commit-Position: refs/heads/master@{#40667}

Powered by Google App Engine
This is Rietveld 408576698