Ignore adding and changing non-Dart files.

Ignore adding and changing non-Dart files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b39d156ea68a99c8ab65f5280a86bf803576eefe

[Brian Wilkerson, 2016-10-31 18:03:47]

https://codereview.chromium.org/2463723004/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2463723004/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:726: static bool
_isDartFile(String path) {
Can we use AnalysisEngine.isDartFileName?

What about changes to analysis options files, or .packages files?

[scheglov, 2016-10-31 18:14:01]

PTAL

https://codereview.chromium.org/2463723004/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2463723004/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:726: static bool
_isDartFile(String path) {
On 2016/10/31 18:03:47, Brian Wilkerson wrote:
> Can we use AnalysisEngine.isDartFileName?

  Done.

> What about changes to analysis options files, or .packages files?

These changes should be handled elsewhere.
Especially .packages files - they change SourceFactory, and it should be fixed
in a particular AnalysisDriver instance.

I don't know about analysis options, but probably the same - it should be
handled externally.
If anything there are changes that force us exclude/include new files and they
are handled by the client.

[Brian Wilkerson, 2016-10-31 18:22:06]

lgtm

[scheglov, 2016-10-31 18:24:29]

Description was changed from

==========
Ignore adding and changing non-Dart files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Ignore adding and changing non-Dart files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b39d156ea68a99c8ab65f5280a86bf803576eefe
==========

[scheglov, 2016-10-31 18:24:30]

Committed patchset #2 (id:20001) manually as
b39d156ea68a99c8ab65f5280a86bf803576eefe (presubmit successful).

[Paul Berry, 2016-10-31 20:15:02]

lgtm