Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/offline_pages/background/request_queue.h

Issue 2463713003: [Offline Pages] Converts MarkAttemptCompleted to use TaskQueue (Closed)
Patch Set: Ternary nit and format fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue.h
diff --git a/components/offline_pages/background/request_queue.h b/components/offline_pages/background/request_queue.h
index 7ad0e49da4618ec9f5e853eab1bb36834c3e344b..3168ea1d90539654e40e83f4ca3f6a44adade9bf 100644
--- a/components/offline_pages/background/request_queue.h
+++ b/components/offline_pages/background/request_queue.h
@@ -78,11 +78,6 @@ class RequestQueue {
void AddRequest(const SavePageRequest& request,
const AddRequestCallback& callback);
- // Updates a request in the request queue if a request with matching ID
- // exists. Does nothing otherwise. Result is returned through |callback|.
- void UpdateRequest(const SavePageRequest& request,
- const UpdateRequestCallback& callback);
-
// Removes the requests matching the |request_ids|. Result is returned through
// |callback|. If a request id cannot be removed, this will still remove the
// others.
@@ -103,11 +98,10 @@ class RequestQueue {
// |callback|.
void MarkAttemptAborted(int64_t request_id, const UpdateCallback& callback);
- void GetForUpdateDone(
- const RequestQueue::UpdateRequestCallback& update_callback,
- const SavePageRequest& update_request,
- bool success,
- std::vector<std::unique_ptr<SavePageRequest>> requests);
+ // Marks attempt with |request_id| as completed. The attempt may have
+ // completed with either success or failure (not denoted here). Results
+ // are returned through |callback|.
+ void MarkAttemptCompleted(int64_t request_id, const UpdateCallback& callback);
private:
// Callback used by |PurgeRequests|.
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_queue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698