Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: components/offline_pages/background/request_queue_unittest.cc

Issue 2463713003: [Offline Pages] Converts MarkAttemptCompleted to use TaskQueue (Closed)
Patch Set: Fixed some lint Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_unittest.cc
diff --git a/components/offline_pages/background/request_queue_unittest.cc b/components/offline_pages/background/request_queue_unittest.cc
index 9018999b7abcf18871441fb56726ccf02b0b74bb..add1b7d67be53057f217bd2b10a09cb46fad6805 100644
--- a/components/offline_pages/background/request_queue_unittest.cc
+++ b/components/offline_pages/background/request_queue_unittest.cc
@@ -5,6 +5,7 @@
#include "components/offline_pages/background/request_queue.h"
#include <memory>
+#include <utility>
#include "base/bind.h"
#include "base/test/test_simple_task_runner.h"
@@ -499,4 +500,34 @@ TEST_F(RequestQueueTest, MarkAttemptAbortedRequestNotPresent) {
EXPECT_EQ(0ul, update_requests_result()->updated_items.size());
}
+TEST_F(RequestQueueTest, MarkAttemptCompleted) {
+ base::Time creation_time = base::Time::Now();
+ SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
+ kUserRequested);
+ queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
+ base::Unretained(this)));
+ PumpLoop();
+
+ // Start request.
+ queue()->MarkAttemptStarted(kRequestId,
+ base::Bind(&RequestQueueTest::UpdateRequestsDone,
+ base::Unretained(this)));
+ PumpLoop();
+ ClearResults();
+
+ queue()->MarkAttemptCompleted(
+ kRequestId, base::Bind(&RequestQueueTest::UpdateRequestsDone,
+ base::Unretained(this)));
+ PumpLoop();
+
+ ASSERT_TRUE(update_requests_result());
+ EXPECT_EQ(1UL, update_requests_result()->item_statuses.size());
+ EXPECT_EQ(kRequestId, update_requests_result()->item_statuses.at(0).first);
+ EXPECT_EQ(ItemActionStatus::SUCCESS,
+ update_requests_result()->item_statuses.at(0).second);
+ EXPECT_EQ(1UL, update_requests_result()->updated_items.size());
+ EXPECT_EQ(SavePageRequest::RequestState::AVAILABLE,
+ update_requests_result()->updated_items.at(0).request_state());
+}
+
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698