[Offline Pages] Converts MarkAttemptCompleted to use TaskQueue

components/offline_pages/background/request_queue.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 62 matching lines @@
 
   // Adds |request| to the request queue. Result is returned through |callback|.
   // In case adding the request violates policy, the result will fail with
   // appropriate result. Callback will also return a copy of a request with all
   // fields set.
   void AddRequest(const SavePageRequest& request,
                   const AddRequestCallback& callback);
 
   // Updates a request in the request queue if a request with matching ID
   // exists. Does nothing otherwise. Result is returned through |callback|.
   void UpdateRequest(const SavePageRequest& request,

[fgorski, 2016/10/31 20:33:50]

Please check if this could be removed with the change you are making, or is
there anything blocking that. I would love to see this one go.

[dougarnett, 2016/10/31 22:05:52]

Done.

                      const UpdateRequestCallback& callback);
 
   // Removes the requests matching the |request_ids|. Result is returned through
   // |callback|.  If a request id cannot be removed, this will still remove the
   // others.
   void RemoveRequests(const std::vector<int64_t>& request_ids,
                       const UpdateCallback& callback);
 
   // Changes the state to |new_state| for requests matching the
   // |request_ids|. Results are returned through |callback|.
   void ChangeRequestsState(const std::vector<int64_t>& request_ids,
                            const SavePageRequest::RequestState new_state,
                            const UpdateCallback& callback);
 
   // Marks attempt with |request_id| as started. Results are returned through
   // |callback|.
   void MarkAttemptStarted(int64_t request_id, const UpdateCallback& callback);
 
   // Marks attempt with |request_id| as aborted. Results are returned through
   // |callback|.
   void MarkAttemptAborted(int64_t request_id, const UpdateCallback& callback);
 
+  // Marks attempt with |request_id| as completed. The attempt may have
+  // completed with either success or failure (not denoted here). Results
+  // are returned through |callback|.
+  void MarkAttemptCompleted(int64_t request_id, const UpdateCallback& callback);
+
   void GetForUpdateDone(
       const RequestQueue::UpdateRequestCallback& update_callback,
       const SavePageRequest& update_request,
       bool success,
       std::vector<std::unique_ptr<SavePageRequest>> requests);
 
  private:
   // Callback used by |PurgeRequests|.
   typedef base::Callback<void(UpdateRequestResult,
                               int /* removed requests count */)>
@@ skipping 11 matching lines @@
 
   // Allows us to pass a weak pointer to callbacks.
   base::WeakPtrFactory<RequestQueue> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RequestQueue);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_