Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2463713002: Replace unique_ptr.reset with std::move() in resource_bundle.cc (Closed)

Created:
4 years, 1 month ago by sanghee
Modified:
4 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset(other_unique_ptr.release() with std::move() in ui/base/resource/resource_bundle.cc BUG=644626 Committed: https://crrev.com/888d4fd7935dea7bda7a2567ee4b1c801d4dd870 Cr-Commit-Position: refs/heads/master@{#428942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sanghee
@Nico PTAL.
4 years, 1 month ago (2016-10-31 06:28:20 UTC) #3
Nico
lgtm assuming you signed the CLA. Thanks!
4 years, 1 month ago (2016-10-31 12:40:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463713002/1
4 years, 1 month ago (2016-11-01 04:05:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 05:20:09 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 05:22:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/888d4fd7935dea7bda7a2567ee4b1c801d4dd870
Cr-Commit-Position: refs/heads/master@{#428942}

Powered by Google App Engine
This is Rietveld 408576698