Initialy renderer ppapi host in ppapi_unittests to fix nullptr access.

Initialize renderer ppapi host in ppapi_unittests to fix nullptr access.

Otherwise, PepperPluginInstanceImpl will call
host_impl->CreateInProcessResourceCreationAPI(this) on nullptr.

The bug was found by running the tests under UBSan.

BUG=607996
Committed: https://crrev.com/dd5416a6158105826292b69875c214464000d7b3
Cr-Commit-Position: refs/heads/master@{#429027}

[krasin1, 2016-10-31 23:08:53]

krasin@chromium.org changed reviewers:
+ tommi@chromium.org

[krasin1, 2016-10-31 23:08:58]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[krasin1, 2016-10-31 23:09:07]

Description was changed from

==========
Initialy renderer ppapi host in ppapi_unittests to fix nullptr access.

Otherwise, PepperPluginInstanceImpl will call
host_impl->CreateInProcessResourceCreationAPI(this) on nullptr.

The bug was found by running the tests under UBSan.

BUG=607996
==========

to

==========
Initialize renderer ppapi host in ppapi_unittests to fix nullptr access.

Otherwise, PepperPluginInstanceImpl will call
host_impl->CreateInProcessResourceCreationAPI(this) on nullptr.

The bug was found by running the tests under UBSan.

BUG=607996
==========

[commit-bot: I haz the power, 2016-10-31 23:09:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:26:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:26:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[krasin1, 2016-10-31 23:38:22]

On 2016/10/31 23:08:54, krasin1 wrote:

So, the issue here is a missing link time dependency on
https://cs.chromium.org/chromium/src/content/renderer/pepper/renderer_ppapi_h...

An input from a code owner is appreciated.

[krasin1, 2016-11-01 00:01:52]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 00:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-11-01 00:22:03]

The CQ bit was unchecked by krasin@chromium.org

[krasin1, 2016-11-01 02:04:43]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 02:05:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-11-01 02:10:28]

On 2016/10/31 23:38:22, krasin1 wrote:
> On 2016/10/31 23:08:54, krasin1 wrote:
> 
> So, the issue here is a missing link time dependency on
>
https://cs.chromium.org/chromium/src/content/renderer/pepper/renderer_ppapi_h...

Turns out the problem was not with a dependency, but with the fact that
CreateOnModuleForInProcess had hidden visibility. I have fixed it with adding
CONTENT_EXPORT.

An alternative would be using MockRendererPpapiHost, which I have tried and the
change started to be quite intrusive, as I had to change RendererPpapiHostImpl
into RendererPpapiHost in many places. I am okay to do the change, if it feels
like a better way to go.

Another alternative would be to check if host_impl is NULL here:
https://cs.chromium.org/chromium/src/content/renderer/pepper/pepper_plugin_in...
which feels wrong.

[commit-bot: I haz the power, 2016-11-01 02:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 02:48:49]

Dry run: This issue passed the CQ dry run.

[tommi (sloooow) - chröme, 2016-11-01 07:05:42]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2016-11-01 07:05:42]

lgtm

[commit-bot: I haz the power, 2016-11-01 07:05:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-11-01 07:10:24]

krasin@chromium.org changed reviewers:
+ bbudge@chromium.org

[krasin1, 2016-11-01 07:10:25]

Hello Bill,

can you please review and approve the content/renderer/pepper/ change? It's a
one liner.

Thanks,
krasin

[commit-bot: I haz the power, 2016-11-01 07:11:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 07:11:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bbudge, 2016-11-01 15:03:37]

lgtm

[krasin1, 2016-11-01 16:56:37]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-11-01 16:56:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 17:03:04]

Description was changed from

==========
Initialize renderer ppapi host in ppapi_unittests to fix nullptr access.

Otherwise, PepperPluginInstanceImpl will call
host_impl->CreateInProcessResourceCreationAPI(this) on nullptr.

The bug was found by running the tests under UBSan.

BUG=607996
==========

to

==========
Initialize renderer ppapi host in ppapi_unittests to fix nullptr access.

Otherwise, PepperPluginInstanceImpl will call
host_impl->CreateInProcessResourceCreationAPI(this) on nullptr.

The bug was found by running the tests under UBSan.

BUG=607996
==========

[commit-bot: I haz the power, 2016-11-01 17:03:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-01 17:22:38]

Description was changed from

==========
Initialize renderer ppapi host in ppapi_unittests to fix nullptr access.

Otherwise, PepperPluginInstanceImpl will call
host_impl->CreateInProcessResourceCreationAPI(this) on nullptr.

The bug was found by running the tests under UBSan.

BUG=607996
==========

to

==========
Initialize renderer ppapi host in ppapi_unittests to fix nullptr access.

Otherwise, PepperPluginInstanceImpl will call
host_impl->CreateInProcessResourceCreationAPI(this) on nullptr.

The bug was found by running the tests under UBSan.

BUG=607996

Committed: https://crrev.com/dd5416a6158105826292b69875c214464000d7b3
Cr-Commit-Position: refs/heads/master@{#429027}
==========

[commit-bot: I haz the power, 2016-11-01 17:22:39]

Patchset 2 (id:??) landed as
https://crrev.com/dd5416a6158105826292b69875c214464000d7b3
Cr-Commit-Position: refs/heads/master@{#429027}