Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2463703005: Update WebUI Cert Viewer with additional algorithms (Closed)

Created:
4 years, 1 month ago by Ryan Sleevi
Modified:
4 years, 1 month ago
Reviewers:
ainslie, rolfe, mattm
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebUI Cert Viewer with additional algorithms Add several EC algorithms to the viewer UI, as well as those OIDs related to EV certificates. This ensures that the WebUI version is similarly detailed as the native UIs on Windows/OS X. BUG=658850 Committed: https://crrev.com/5a5a26864366257845b1fa0ce7d22dcefdf751f1 Cr-Commit-Position: refs/heads/master@{#430012}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Right buffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -22 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +37 lines, -1 line 0 comments Download
M chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp View 1 8 chunks +64 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Ryan Sleevi
Matt: Can you review the mechanical changes? Alex/Rebecca: These strings are largely untranslatable, but bring ...
4 years, 1 month ago (2016-10-31 20:57:14 UTC) #2
mattm
https://codereview.chromium.org/2463703005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2463703005/diff/1/chrome/app/generated_resources.grd#newcode2750 chrome/app/generated_resources.grd:2750: + <message translateable="false" name="IDS_CERT_OID_EV_INCORPORATION_LOCALITY" desc=""> not used? https://codereview.chromium.org/2463703005/diff/1/chrome/app/generated_resources.grd#newcode2753 chrome/app/generated_resources.grd:2753: ...
4 years, 1 month ago (2016-11-02 19:23:32 UTC) #4
Ryan Sleevi
On 2016/11/02 19:23:32, mattm wrote: > https://codereview.chromium.org/2463703005/diff/1/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/2463703005/diff/1/chrome/app/generated_resources.grd#newcode2750 > ...
4 years, 1 month ago (2016-11-02 19:24:53 UTC) #5
Ryan Sleevi
PTAL; ainslie gave LG on email thread.
4 years, 1 month ago (2016-11-03 04:16:46 UTC) #6
mattm
lgtm
4 years, 1 month ago (2016-11-03 21:15:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463703005/20001
4 years, 1 month ago (2016-11-04 19:25:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 21:07:09 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 21:10:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a5a26864366257845b1fa0ce7d22dcefdf751f1
Cr-Commit-Position: refs/heads/master@{#430012}

Powered by Google App Engine
This is Rietveld 408576698