Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2463683002: Remove stl_util's deletion function use from components/query_parser/. (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion function use from components/query_parser/. BUG=555865, 554289 Committed: https://crrev.com/8e000a71c7cf5b5b0100f7786b23c4615679a40a Cr-Commit-Position: refs/heads/master@{#429341}

Patch Set 1 #

Patch Set 2 : include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -49 lines) Patch
M components/bookmarks/browser/bookmark_index.h View 1 chunk +4 lines, -5 lines 0 comments Download
M components/bookmarks/browser/bookmark_index.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M components/history/core/browser/url_database.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M components/query_parser/query_parser.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
M components/query_parser/query_parser.cc View 9 chunks +19 lines, -20 lines 0 comments Download
M components/query_parser/query_parser_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Avi (use Gerrit)
4 years, 1 month ago (2016-10-30 23:26:24 UTC) #7
Avi (use Gerrit)
4 years, 1 month ago (2016-11-02 14:48:09 UTC) #11
sky
LGTM
4 years, 1 month ago (2016-11-02 15:46:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463683002/20001
4 years, 1 month ago (2016-11-02 17:05:08 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 18:06:42 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 18:23:39 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e000a71c7cf5b5b0100f7786b23c4615679a40a
Cr-Commit-Position: refs/heads/master@{#429341}

Powered by Google App Engine
This is Rietveld 408576698