Stop supporting old Gerrit CQ tryjob properties.

Stop supporting old Gerrit CQ tryjob properties.

R=machenbach@chromium.org
BUG=chromium:645616
Committed: https://chromium.googlesource.com/chromium/tools/build/+/b78581e2d8b96f56424b901c3224b5268813b2f6

[tandrii(chromium), 2016-10-30 15:56:23]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 15:56:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 16:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 16:08:55]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-11-07 11:23:23]

PTAL

[Michael Achenbach, 2016-11-07 12:54:00]

lgtm

https://codereview.chromium.org/2463653002/diff/1/scripts/slave/recipes/run_p...
File scripts/slave/recipes/run_presubmit.py (left):

https://codereview.chromium.org/2463653002/diff/1/scripts/slave/recipes/run_p...
scripts/slave/recipes/run_presubmit.py:176:
api.test('infra_with_runhooks_and_gerrit_deprecated') +
Missing deletion of the file?

https://codereview.chromium.org/2463653002/diff/1/scripts/slave/recipes/run_p...
File scripts/slave/recipes/run_presubmit.py (right):

https://codereview.chromium.org/2463653002/diff/1/scripts/slave/recipes/run_p...
scripts/slave/recipes/run_presubmit.py:66: gerrit_url =
api.properties.get('patch_gerrit_url')
Same as in another CL: Does it make sense to use get? Will it not just delay a
possible error? How about []?

[tandrii(chromium), 2016-11-07 13:01:08]

https://codereview.chromium.org/2463653002/diff/1/scripts/slave/recipes/run_p...
File scripts/slave/recipes/run_presubmit.py (left):

https://codereview.chromium.org/2463653002/diff/1/scripts/slave/recipes/run_p...
scripts/slave/recipes/run_presubmit.py:176:
api.test('infra_with_runhooks_and_gerrit_deprecated') +
On 2016/11/07 12:54:00, machenbach (slow) wrote:
> Missing deletion of the file?

Done.

https://codereview.chromium.org/2463653002/diff/1/scripts/slave/recipes/run_p...
File scripts/slave/recipes/run_presubmit.py (right):

https://codereview.chromium.org/2463653002/diff/1/scripts/slave/recipes/run_p...
scripts/slave/recipes/run_presubmit.py:66: gerrit_url =
api.properties.get('patch_gerrit_url')
On 2016/11/07 12:54:00, machenbach (slow) wrote:
> Same as in another CL: Does it make sense to use get? Will it not just delay a
> possible error? How about []?

sorry. Simplified.

[tandrii(chromium), 2016-11-07 13:01:11]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-11-07 13:01:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2463653002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2016-11-07 13:01:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 13:11:42]

Description was changed from

==========
Stop supporting old Gerrit CQ tryjob properties.

R=machenbach@chromium.org
BUG=chromium:645616
==========

to

==========
Stop supporting old Gerrit CQ tryjob properties.

R=machenbach@chromium.org
BUG=chromium:645616

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/b78581e2d8b96f56424b...
==========

[commit-bot: I haz the power, 2016-11-07 13:11:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/b78581e2d8b96f56424b...

[Michael Achenbach, 2016-11-07 13:14:07]

lgtm