Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2463603002: Remove the use of STLDeleteContainerPointers from ScopedVector. (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Mark Mentovai, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, tzik, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, chromoting-reviews_chromium.org, browser-components-watch_chromium.org, gavinp+memory_chromium.org, nhiroki, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, tdresser+watch_chromium.org, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the use of STLDeleteContainerPointers from ScopedVector. This is the last use of STLDeleteContainerPointers. BUG=555865 Committed: https://crrev.com/ea835b9c56dd450d9f34a1248149aca0c60e8a58 Cr-Commit-Position: refs/heads/master@{#428859}

Patch Set 1 #

Patch Set 2 : reparent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M base/memory/scoped_vector.h View 4 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/phone_field_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/multi_channel_resampler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/codec/audio_encoder_opus.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/test/test_event_target.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Avi (use Gerrit)
PTAL. All the include fixing is because we drop stl_util.h from scoped_vector.h, and so several ...
4 years, 1 month ago (2016-10-30 18:19:42 UTC) #10
jam
On 2016/10/30 18:19:42, Avi wrote: > PTAL. > > All the include fixing is because ...
4 years, 1 month ago (2016-10-31 16:53:48 UTC) #11
Avi (use Gerrit)
Mark, ptal.
4 years, 1 month ago (2016-10-31 18:23:00 UTC) #13
Mark Mentovai
LGTM in base.
4 years, 1 month ago (2016-10-31 19:52:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463603002/20001
4 years, 1 month ago (2016-10-31 21:13:09 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 23:17:30 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 23:21:09 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea835b9c56dd450d9f34a1248149aca0c60e8a58
Cr-Commit-Position: refs/heads/master@{#428859}

Powered by Google App Engine
This is Rietveld 408576698