Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1787)

Unified Diff: runtime/vm/simulator_dbc.cc

Issue 2463593002: VM: Enable branch merging of isnan, isinf. (Closed)
Patch Set: DBC support Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/simulator_dbc.cc
diff --git a/runtime/vm/simulator_dbc.cc b/runtime/vm/simulator_dbc.cc
index c3998aff11a6ba832c47f211676d9cb4c8b44108..ddc01b9653be8cd345ba33f5cbb24ec2562e9cca 100644
--- a/runtime/vm/simulator_dbc.cc
+++ b/runtime/vm/simulator_dbc.cc
@@ -2229,16 +2229,16 @@ RawObject* Simulator::Call(const Code& code,
}
{
- BYTECODE(DoubleIsNaN, A_D);
- const double v = bit_cast<double, RawObject*>(FP[rD]);
- FP[rA] = isnan(v) ? true_value : false_value;
+ BYTECODE(DoubleIsNaN, A);
+ const double v = bit_cast<double, RawObject*>(FP[rA]);
+ if (!isnan(v)) pc++;
zra 2016/10/31 17:28:15 Please use {}
Florian Schneider 2016/10/31 18:48:17 Done.
DISPATCH();
}
{
- BYTECODE(DoubleIsInfinite, A_D);
- const double v = bit_cast<double, RawObject*>(FP[rD]);
- FP[rA] = isinf(v) ? true_value : false_value;
+ BYTECODE(DoubleIsInfinite, A);
+ const double v = bit_cast<double, RawObject*>(FP[rA]);
+ if (!isinf(v)) pc++;
zra 2016/10/31 17:28:15 ditto
Florian Schneider 2016/10/31 18:48:17 Done.
DISPATCH();
}
« runtime/vm/intermediate_language.cc ('K') | « runtime/vm/intermediate_language_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698