third_party/WebKit/Source/core/layout/LayoutListItem.cpp - Issue 2463573002: Problem: Blink list-item-position is inside for unstyled list items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListItem.cpp

Issue 2463573002: Problem: Blink list-item-position is inside for unstyled list items Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutListItem.h ('k') | third_party/WebKit/Source/core/layout/LayoutListMarker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutListItem.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp

index badb3a06f52091495cb3760cd7c472f975a045fc..d463d30e9146d41c355659ca957d7c82b026e598 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp

@@ -40,7 +40,6 @@ LayoutListItem::LayoutListItem(Element* element)

, m_marker(nullptr)

, m_hasExplicitValue(false)

, m_isValueUpToDate(false)

- , m_notInList(false)

{

setInline(false);

@@ -468,11 +467,6 @@ void LayoutListItem::clearExplicitValue()

explicitValueChanged();

}

-void LayoutListItem::setNotInList(bool notInList)

- m_notInList = notInList;

static LayoutListItem* previousOrNextItem(bool isListReversed, Node* list, LayoutListItem* item)

{

return isListReversed ? previousListItem(list, item) : nextListItem(list, item);