Fix for inlining async methods/getters.

Fix for inlining async methods/getters.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3319e6d0e3bf7ca8a2b43b0d2cd4c6304583f6f2

[Brian Wilkerson, 2016-10-31 14:00:39]

lgtm

https://codereview.chromium.org/2463493002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/refactoring/inline_method_test.dart
(right):

https://codereview.chromium.org/2463493002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/refactoring/inline_method_test.dart:714:
test_getter_async() {
Given that we are inlining 'test' into 'foo, perhaps test the cases where
- foo is async
- foo is async*
- foo is sync*
- test is async*
- foo does not return a Future
Also, perhaps test the case where we are inlining into multiple non-async
methods.

[scheglov, 2016-10-31 15:48:29]

https://codereview.chromium.org/2463493002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/refactoring/inline_method_test.dart
(right):

https://codereview.chromium.org/2463493002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/refactoring/inline_method_test.dart:714:
test_getter_async() {
On 2016/10/31 14:00:38, Brian Wilkerson wrote:
> Given that we are inlining 'test' into 'foo, perhaps test the cases where
> - foo is async
> - foo is async*
> - foo is sync*
> - test is async*
> - foo does not return a Future
> Also, perhaps test the case where we are inlining into multiple non-async
> methods.

Done.

[scheglov, 2016-10-31 15:48:42]

Description was changed from

==========
Fix for inlining async methods/getters.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Fix for inlining async methods/getters.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3319e6d0e3bf7ca8a2b43b0d2cd4c6304583f6f2
==========

[scheglov, 2016-10-31 15:48:44]

Committed patchset #2 (id:20001) manually as
3319e6d0e3bf7ca8a2b43b0d2cd4c6304583f6f2 (presubmit successful).