swarming: allow privileged users to schedule high priority tasks

swarming: allow privileged users to schedule high priority tasks

allow privileged users to schedule tasks with priority < 100
Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446
Committed: https://github.com/luci/luci-py/commit/f6ed6fef610f312800f5644ca0c4889d67fd2b20

[nodir, 2016-10-28 19:09:29]

PTAL

[Vadim Sh., 2016-10-28 19:48:44]

lgtm with nit

please also fix typo in CL name and description

https://codereview.chromium.org/2463483002/diff/1/appengine/swarming/server/a...
File appengine/swarming/server/acl.py (right):

https://codereview.chromium.org/2463483002/diff/1/appengine/swarming/server/a...
appengine/swarming/server/acl.py:21: HIGH_PRIORITY_TASKS_GROUP =
'swarming-high-priority-task'
swarming-high-priority-tasks? (with 's')

I'm not very excited about the name but I can't think of a better alternative.

[nodir, 2016-10-28 19:58:40]

Description was changed from

==========
swarming: introduce swarming-high-priority-taskg group

swarming-high-priority-task group defines who can schedule tasks with
priority < 100. Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446
==========

to

==========
swarming: introduce swarming-high-priority-task group

swarming-high-priority-task group defines who can schedule tasks with
priority < 100. Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446
==========

[nodir, 2016-10-28 19:59:46]

Description was changed from

==========
swarming: introduce swarming-high-priority-task group

swarming-high-priority-task group defines who can schedule tasks with
priority < 100. Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446
==========

to

==========
swarming: introduce swarming-high-priority-tasks group

swarming-high-priority-tasks group defines who can schedule tasks with
priority < 100. Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446
==========

[nodir, 2016-10-28 20:00:14]

https://codereview.chromium.org/2463483002/diff/1/appengine/swarming/server/a...
File appengine/swarming/server/acl.py (right):

https://codereview.chromium.org/2463483002/diff/1/appengine/swarming/server/a...
appengine/swarming/server/acl.py:21: HIGH_PRIORITY_TASKS_GROUP =
'swarming-high-priority-task'
On 2016/10/28 19:48:44, Vadim Sh. wrote:
> swarming-high-priority-tasks? (with 's')

Done
 
> I'm not very excited about the name but I can't think of a better alternative.

yeah, me neither. Maybe maruel will have a better alternative

[nodir, 2016-10-31 21:44:33]

Description was changed from

==========
swarming: introduce swarming-high-priority-tasks group

swarming-high-priority-tasks group defines who can schedule tasks with
priority < 100. Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446
==========

to

==========
swarming: allow privileged users to schedule high priority tasks

allow privileged users to schedule tasks with priority < 100
Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446
==========

[nodir, 2016-10-31 21:45:18]

repurposed the CL a bit

[Vadim Sh., 2016-10-31 21:46:14]

lgtm

[nodir, 2016-10-31 21:48:11]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:48:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 21:51:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:51:30]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/32358a1fc758c410)

[nodir, 2016-10-31 22:05:20]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-10-31 22:05:21]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2463483002/#ps60001
(title: "allow privileged users to schedule high priority tasks")

[commit-bot: I haz the power, 2016-10-31 22:05:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 22:09:24]

Description was changed from

==========
swarming: allow privileged users to schedule high priority tasks

allow privileged users to schedule tasks with priority < 100
Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446
==========

to

==========
swarming: allow privileged users to schedule high priority tasks

allow privileged users to schedule tasks with priority < 100
Context is crbug.com/660446

R=maruel@chromium.org, vadimsh@chromium.org
BUG=660446

Committed:
https://github.com/luci/luci-py/commit/f6ed6fef610f312800f5644ca0c4889d67fd2b20
==========

[commit-bot: I haz the power, 2016-10-31 22:09:25]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/f6ed6fef610f312800f5644ca0c4889d67fd2b20

[M-A Ruel, 2016-10-31 22:11:20]

https://codereview.chromium.org/2463483002/diff/60001/appengine/swarming/serv...
File appengine/swarming/server/acl.py (right):

https://codereview.chromium.org/2463483002/diff/60001/appengine/swarming/serv...
appengine/swarming/server/acl.py:60: def is_bot_or_privileged_user():
^^ :/

[nodir, 2016-10-31 22:18:15]

https://codereview.chromium.org/2463483002/diff/60001/appengine/swarming/serv...
File appengine/swarming/server/acl.py (right):

https://codereview.chromium.org/2463483002/diff/60001/appengine/swarming/serv...
appengine/swarming/server/acl.py:60: def is_bot_or_privileged_user():
On 2016/10/31 22:11:20, M-A Ruel wrote:
> ^^ :/

it looks like you are proposing to call this function in other files, but in
that case the knowledge "who can schedule high priority tasks" is in many
places, rather than one.

I could use is_bot_or_privileged_user in can_schedule_high_priority_tasks.
the function seems to be marked to be deprecated though