Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: printing/backend/print_backend.h

Issue 2463473002: Present the printer list from preferences for Chrome OS. (Closed)
Patch Set: tidy Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/backend/print_backend.h
diff --git a/printing/backend/print_backend.h b/printing/backend/print_backend.h
index 46b0801323db12cec7751f5108d54adb99f00100..4dc32554b3dd8ca79b997b2d4b19a3350fde61b9 100644
--- a/printing/backend/print_backend.h
+++ b/printing/backend/print_backend.h
@@ -28,6 +28,7 @@ struct PRINTING_EXPORT PrinterBasicInfo {
PrinterBasicInfo(const PrinterBasicInfo& other);
~PrinterBasicInfo();
+ std::string printer_id;
Lei Zhang 2016/10/28 21:55:51 Is this field going to be ChromeOS only?
skau 2016/11/02 22:00:03 I've added a guard for now. It's probably useful
Lei Zhang 2016/11/02 22:40:59 Ok, so in patch set 2 you had [printer_id, printer
skau 2016/11/02 23:38:16 Sorry about the thrashing. display_name is more c
std::string printer_name;
std::string printer_description;
int printer_status;

Powered by Google App Engine
This is Rietveld 408576698