Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2463463004: [Sync] Rename wifi_sync to sync_wifi. (Closed)

Created:
4 years, 1 month ago by maxbogue
Modified:
4 years, 1 month ago
Reviewers:
zel, blundell
CC:
chromium-reviews, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Rename wifi_sync to sync_wifi. All sync model type implementations that have their own component should follow the sync_modeltype naming convention. - Moved files and ran mass-rename.py - Fixed namespaces - Ran formatter BUG=659265 TBR=zelidrag Committed: https://crrev.com/53381b6f53fe660efe59a76837af0ac51058e9b9 Cr-Commit-Position: refs/heads/master@{#429030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -2205 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_wifi_credentials_sync_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/wifi_credentials_helper.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/wifi_credentials_helper.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync_wifi/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync_wifi/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/sync_wifi/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/sync_wifi/network_state_helper_chromeos.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/sync_wifi/network_state_helper_chromeos.cc View 4 chunks +6 lines, -9 lines 0 comments Download
A + components/sync_wifi/wifi_config_delegate.h View 2 chunks +6 lines, -7 lines 0 comments Download
A + components/sync_wifi/wifi_config_delegate_chromeos.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/sync_wifi/wifi_config_delegate_chromeos.cc View 4 chunks +5 lines, -6 lines 0 comments Download
A + components/sync_wifi/wifi_config_delegate_chromeos_unittest.cc View 7 chunks +27 lines, -35 lines 0 comments Download
A + components/sync_wifi/wifi_credential.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + components/sync_wifi/wifi_credential.cc View 4 chunks +12 lines, -18 lines 0 comments Download
A + components/sync_wifi/wifi_credential_syncable_service.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + components/sync_wifi/wifi_credential_syncable_service.cc View 5 chunks +8 lines, -9 lines 0 comments Download
A + components/sync_wifi/wifi_credential_syncable_service_factory.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/sync_wifi/wifi_credential_syncable_service_factory.cc View 4 chunks +11 lines, -13 lines 0 comments Download
A + components/sync_wifi/wifi_credential_syncable_service_unittest.cc View 4 chunks +17 lines, -24 lines 0 comments Download
A + components/sync_wifi/wifi_credential_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + components/sync_wifi/wifi_security_class.h View 3 chunks +6 lines, -7 lines 0 comments Download
A + components/sync_wifi/wifi_security_class.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync_wifi/wifi_security_class_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync_wifi/wifi_security_class_chromeos_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync_wifi/wifi_security_class_unittest.cc View 2 chunks +11 lines, -11 lines 0 comments Download
D components/wifi_sync/BUILD.gn View 1 chunk +0 lines, -59 lines 0 comments Download
D components/wifi_sync/DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
D components/wifi_sync/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/wifi_sync/network_state_helper_chromeos.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/wifi_sync/network_state_helper_chromeos.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D components/wifi_sync/wifi_config_delegate.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/wifi_sync/wifi_config_delegate_chromeos.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/wifi_sync/wifi_config_delegate_chromeos.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc View 1 chunk +0 lines, -231 lines 0 comments Download
D components/wifi_sync/wifi_credential.h View 1 chunk +0 lines, -94 lines 0 comments Download
D components/wifi_sync/wifi_credential.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D components/wifi_sync/wifi_credential_syncable_service.h View 1 chunk +0 lines, -94 lines 0 comments Download
D components/wifi_sync/wifi_credential_syncable_service.cc View 1 chunk +0 lines, -235 lines 0 comments Download
D components/wifi_sync/wifi_credential_syncable_service_factory.h View 1 chunk +0 lines, -77 lines 0 comments Download
D components/wifi_sync/wifi_credential_syncable_service_factory.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D components/wifi_sync/wifi_credential_syncable_service_unittest.cc View 1 chunk +0 lines, -343 lines 0 comments Download
D components/wifi_sync/wifi_credential_unittest.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D components/wifi_sync/wifi_security_class.h View 1 chunk +0 lines, -59 lines 0 comments Download
D components/wifi_sync/wifi_security_class.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D components/wifi_sync/wifi_security_class_chromeos.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D components/wifi_sync/wifi_security_class_chromeos_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D components/wifi_sync/wifi_security_class_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
maxbogue
Colin, PTAL!
4 years, 1 month ago (2016-10-30 21:36:26 UTC) #6
blundell
lgtm!
4 years, 1 month ago (2016-10-31 19:11:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463463004/1
4 years, 1 month ago (2016-10-31 19:12:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/293361)
4 years, 1 month ago (2016-10-31 19:21:19 UTC) #11
maxbogue
TBR zelidrag@ for //chrome/browser/chromeos/BUILD.gn
4 years, 1 month ago (2016-10-31 19:26:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463463004/1
4 years, 1 month ago (2016-10-31 19:27:56 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/322494)
4 years, 1 month ago (2016-10-31 22:26:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463463004/1
4 years, 1 month ago (2016-11-01 16:21:37 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 17:18:10 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 17:22:48 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53381b6f53fe660efe59a76837af0ac51058e9b9
Cr-Commit-Position: refs/heads/master@{#429030}

Powered by Google App Engine
This is Rietveld 408576698