[ios] Adds ChromiumBrowserProvider.

[ios] Adds ChromiumBrowserProvider.

This class provides fallback functionality for certain browser features such as
voice search.

BUG=656617
TEST=None

Committed: https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c
Cr-Commit-Position: refs/heads/master@{#429592}

[rohitrao (ping after 24h), 2016-10-28 20:23:16]

rohitrao@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-11-02 16:27:41]

https://codereview.chromium.org/2463463002/diff/1/ios/chrome/browser/provider...
File ios/chrome/browser/providers/chromium_browser_provider.h (right):

https://codereview.chromium.org/2463463002/diff/1/ios/chrome/browser/provider...
ios/chrome/browser/providers/chromium_browser_provider.h:19: id<UrlLoader>
loader) const override;
NS_RETURNS_RETAINED

https://codereview.chromium.org/2463463002/diff/1/ios/chrome/browser/provider...
File ios/chrome/browser/providers/chromium_logo_controller.mm (right):

https://codereview.chromium.org/2463463002/diff/1/ios/chrome/browser/provider...
ios/chrome/browser/providers/chromium_logo_controller.mm:18: if ((self = [super
init])) {
Since this is new code, can you convert this file to ARC? It will make the file
simpler (you can @synthesize the view property too).

[rohitrao (ping after 24h), 2016-11-02 19:10:33]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[rohitrao (ping after 24h), 2016-11-02 19:10:44]

How does this look?

https://codereview.chromium.org/2463463002/diff/1/ios/chrome/browser/provider...
File ios/chrome/browser/providers/chromium_browser_provider.h (right):

https://codereview.chromium.org/2463463002/diff/1/ios/chrome/browser/provider...
ios/chrome/browser/providers/chromium_browser_provider.h:19: id<UrlLoader>
loader) const override;
On 2016/11/02 16:27:41, sdefresne wrote:
> NS_RETURNS_RETAINED

Done.

https://codereview.chromium.org/2463463002/diff/1/ios/chrome/browser/provider...
File ios/chrome/browser/providers/chromium_logo_controller.mm (right):

https://codereview.chromium.org/2463463002/diff/1/ios/chrome/browser/provider...
ios/chrome/browser/providers/chromium_logo_controller.mm:18: if ((self = [super
init])) {
On 2016/11/02 16:27:41, sdefresne wrote:
> Since this is new code, can you convert this file to ARC? It will make the
file
> simpler (you can @synthesize the view property too).

Done.

[commit-bot: I haz the power, 2016-11-02 19:11:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 20:19:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 20:19:39]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-11-02 20:36:29]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 20:37:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 22:04:21]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-11-03 07:56:49]

lgtm

https://codereview.chromium.org/2463463002/diff/40001/ios/chrome/browser/prov...
File ios/chrome/browser/providers/chromium_logo_controller.mm (right):

https://codereview.chromium.org/2463463002/diff/40001/ios/chrome/browser/prov...
ios/chrome/browser/providers/chromium_logo_controller.mm:25: - (UIView*)view {
Remove as you already synthesize this property.

[rohitrao (ping after 24h), 2016-11-03 13:42:46]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-11-03 13:42:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2463463002/#ps60001
(title: "Review.")

[commit-bot: I haz the power, 2016-11-03 13:43:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 15:19:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-03 15:40:55]

Description was changed from

==========
[ios] Adds ChromiumBrowserProvider.

This class provides fallback functionality for certain browser features such as
voice search.

BUG=656617
TEST=None
==========

to

==========
[ios] Adds ChromiumBrowserProvider.

This class provides fallback functionality for certain browser features such as
voice search.

BUG=656617
TEST=None

Committed: https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c
Cr-Commit-Position: refs/heads/master@{#429592}
==========

[commit-bot: I haz the power, 2016-11-03 15:40:56]

Patchset 4 (id:??) landed as
https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c
Cr-Commit-Position: refs/heads/master@{#429592}