Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 246343002: pkg-config-wrapper: use system_libdir for libpath (Closed)

Created:
6 years, 8 months ago by vapier
Modified:
6 years, 8 months ago
Reviewers:
Torne
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

pkg-config-wrapper: use system_libdir for libpath We already have a variable for tracking the system libdir name in the gyp files, so let's use that instead of hardcoding the logic based on the arch. BUG=chromium:219015 TEST=`cbuildbot amd64-generic-tot-chrome-pfq-informational` works

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/emacs/testdata/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/emacs/testdata/media.gyp.fontified View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
vapier
see the main CL https://codereview.chromium.org/244593002/
6 years, 8 months ago (2014-04-22 01:55:24 UTC) #1
Torne
I don't really know anything about this, but from the look of it you're modifying ...
6 years, 8 months ago (2014-04-22 09:58:52 UTC) #2
vapier
I have no idea. I was just grepping for the wrapper. I don't use emacs ...
6 years, 8 months ago (2014-04-22 14:17:24 UTC) #3
Torne
6 years, 8 months ago (2014-04-22 15:00:19 UTC) #4
On 2014/04/22 14:17:24, vapier wrote:
> I have no idea. I was just grepping for the wrapper. I don't use emacs so I
> can't really test.
> 
> if you think it's unnecessary, it's easy for me to drop.

I don't use emacs either and running the test needs some lisp package I don't
have, so yeah.

I'd just abandon this change. This gyp file is not ever used to build anything;
it's just there as a test for the emacs syntax hilighting, so as long as it's
valid syntax it doesn't matter whether it actually *works*. ;)

Powered by Google App Engine
This is Rietveld 408576698