Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2463393002: Fix WebVR crash caused by InterfaceProviderSpec refactoring. (Closed)

Created:
4 years, 1 month ago by cjgrant
Modified:
4 years, 1 month ago
CC:
bshe, amp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebVR crash caused by InterfaceProviderSpec refactoring. BUG= Committed: https://crrev.com/9ac623757139b88db9084bbc6dc993a41b58ad32 Cr-Commit-Position: refs/heads/master@{#429079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
cjgrant
Ben, this fixes a crash that started with commit 275a565819b71dc186f9b4a5249fda24058d364b.
4 years, 1 month ago (2016-11-01 15:54:02 UTC) #2
Ben Goodger (Google)
lgtm, you'll need security review also
4 years, 1 month ago (2016-11-01 16:56:03 UTC) #5
cjgrant
Tom, could you review this one-liner when you have a minute?
4 years, 1 month ago (2016-11-01 17:10:48 UTC) #7
Tom Sepez
RS LGTM
4 years, 1 month ago (2016-11-01 18:29:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463393002/1
4 years, 1 month ago (2016-11-01 18:55:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 19:50:22 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 19:57:45 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ac623757139b88db9084bbc6dc993a41b58ad32
Cr-Commit-Position: refs/heads/master@{#429079}

Powered by Google App Engine
This is Rietveld 408576698