Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2463323003: Fix java classes missing @MainDex. (Closed)

Created:
4 years, 1 month ago by estevenson
Modified:
4 years, 1 month ago
Reviewers:
Ted C, agrieve
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix java classes missing @MainDex. Adding @MainDex to these classes will ensure they are kept in the main dex file even when proguard is used. This will allow us to turn on multidex in release. BUG=657024 Committed: https://crrev.com/c11bed35d016206740715e7b990ef870ba62a5a7 Cr-Commit-Position: refs/heads/master@{#429420}

Patch Set 1 #

Patch Set 2 : Add more classes that need @MainDex #

Messages

Total messages: 11 (5 generated)
estevenson
agrieve@chromium.org: Please review changes in //base tedchoc@chromium.org: Please review everything else
4 years, 1 month ago (2016-11-02 16:24:30 UTC) #3
agrieve
On 2016/11/02 16:24:30, estevenson wrote: > mailto:agrieve@chromium.org: Please review changes in //base > > mailto:tedchoc@chromium.org: ...
4 years, 1 month ago (2016-11-02 16:42:26 UTC) #4
Ted C
lgtm
4 years, 1 month ago (2016-11-02 16:43:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463323003/20001
4 years, 1 month ago (2016-11-02 21:10:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 22:26:44 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 22:31:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c11bed35d016206740715e7b990ef870ba62a5a7
Cr-Commit-Position: refs/heads/master@{#429420}

Powered by Google App Engine
This is Rietveld 408576698