Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2463323002: Convert editing/spelling/spellcheck-attribute-settings-default.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spellcheck-attribute-settings-default.html with spellcheck_test This patch converts the layout test with spellcheck_test as a preparation for implementing idle time spellchecker. This patch also fixes a bug in the last test case of the original file, where element with empty-string spellcheck attribute should be spellchecked when the global default value is false, while the original test case asserts that the element is not checked. BUG=517298 Committed: https://crrev.com/6ee9acea67b949b32cf2b1eff8ff6a7a17d90774 Cr-Commit-Position: refs/heads/master@{#429219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -96 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default.html View 1 chunk +88 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute-settings-default-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Xiaocheng
PTAL. The last case in the original test file asserts no spell checking, but it ...
4 years, 1 month ago (2016-11-01 09:18:18 UTC) #4
Xiaocheng
Oops, I forgot to set reviewer...
4 years, 1 month ago (2016-11-02 03:48:01 UTC) #8
yosin_UTC9
lgtm
4 years, 1 month ago (2016-11-02 06:06:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463323002/1
4 years, 1 month ago (2016-11-02 06:06:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 06:11:12 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 06:15:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ee9acea67b949b32cf2b1eff8ff6a7a17d90774
Cr-Commit-Position: refs/heads/master@{#429219}

Powered by Google App Engine
This is Rietveld 408576698