Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2463233002: Add a BrotliSourceStream fuzzer (Closed)

Created:
4 years, 1 month ago by xunjieli
Modified:
4 years, 1 month ago
Reviewers:
eustas, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, fuzzing_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a BrotliSourceStream fuzzer This CL adds a fuzzer for BrotliSourceStream. BUG=602424 Committed: https://crrev.com/d5ffeaf01d9a1ca1710fb1677471709cbcebb8e9 Cr-Commit-Position: refs/heads/master@{#429004}

Patch Set 1 : self review #

Total comments: 2

Patch Set 2 : Correct typo in gzip file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M net/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A + net/filter/brotli_source_stream_fuzzer.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M net/filter/gzip_source_stream_fuzzer.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
xunjieli
4 years, 1 month ago (2016-10-31 22:25:48 UTC) #4
eustas
lgtm
4 years, 1 month ago (2016-11-01 08:55:49 UTC) #5
mmenke
LGTM https://codereview.chromium.org/2463233002/diff/40001/net/filter/brotli_source_stream_fuzzer.cc File net/filter/brotli_source_stream_fuzzer.cc (left): https://codereview.chromium.org/2463233002/diff/40001/net/filter/brotli_source_stream_fuzzer.cc#oldcode16 net/filter/brotli_source_stream_fuzzer.cc:16: // |data| is used to create a FuzzedSocket. ...
4 years, 1 month ago (2016-11-01 13:56:21 UTC) #6
xunjieli
Thanks! https://codereview.chromium.org/2463233002/diff/40001/net/filter/brotli_source_stream_fuzzer.cc File net/filter/brotli_source_stream_fuzzer.cc (left): https://codereview.chromium.org/2463233002/diff/40001/net/filter/brotli_source_stream_fuzzer.cc#oldcode16 net/filter/brotli_source_stream_fuzzer.cc:16: // |data| is used to create a FuzzedSocket. ...
4 years, 1 month ago (2016-11-01 14:03:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463233002/60001
4 years, 1 month ago (2016-11-01 14:03:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 1 month ago (2016-11-01 15:22:27 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 15:50:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5ffeaf01d9a1ca1710fb1677471709cbcebb8e9
Cr-Commit-Position: refs/heads/master@{#429004}

Powered by Google App Engine
This is Rietveld 408576698