Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: base/metrics/field_trial_param_associator.cc

Issue 2463223002: Store field trial parameters in shared memory (Closed)
Patch Set: check that cache has been cleared in test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/field_trial_param_associator.h ('k') | base/metrics/field_trial_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial_param_associator.cc
diff --git a/base/metrics/field_trial_param_associator.cc b/base/metrics/field_trial_param_associator.cc
index b96cc396df874689af034691d9479a780ae78417..0230b8a8a8d39082d166052eb00303e4ff03919e 100644
--- a/base/metrics/field_trial_param_associator.cc
+++ b/base/metrics/field_trial_param_associator.cc
@@ -37,9 +37,26 @@ bool FieldTrialParamAssociator::AssociateFieldTrialParams(
bool FieldTrialParamAssociator::GetFieldTrialParams(
const std::string& trial_name,
FieldTrialParams* params) {
+ FieldTrial* field_trial = FieldTrialList::Find(trial_name);
+ if (!field_trial)
+ return false;
+
+ // First try the local map, falling back to getting it from shared memory.
+ if (GetFieldTrialParamsWithoutFallback(trial_name, field_trial->group_name(),
+ params)) {
+ return true;
+ }
+
+ // TODO(lawrencewu): add the params to field_trial_params_ for next time.
+ return FieldTrialList::GetParamsFromSharedMemory(field_trial, params);
+}
+
+bool FieldTrialParamAssociator::GetFieldTrialParamsWithoutFallback(
+ const std::string& trial_name,
+ const std::string& group_name,
+ FieldTrialParams* params) {
AutoLock scoped_lock(lock_);
- const std::string group_name = FieldTrialList::FindFullName(trial_name);
const FieldTrialKey key(trial_name, group_name);
if (!ContainsKey(field_trial_params_, key))
return false;
@@ -51,6 +68,12 @@ bool FieldTrialParamAssociator::GetFieldTrialParams(
void FieldTrialParamAssociator::ClearAllParamsForTesting() {
AutoLock scoped_lock(lock_);
field_trial_params_.clear();
+ FieldTrialList::ClearParamsFromSharedMemoryForTesting();
+}
+
+void FieldTrialParamAssociator::ClearAllCachedParamsForTesting() {
+ AutoLock scoped_lock(lock_);
+ field_trial_params_.clear();
}
} // namespace base
« no previous file with comments | « base/metrics/field_trial_param_associator.h ('k') | base/metrics/field_trial_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698