Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: base/metrics/field_trial.h

Issue 2463223002: Store field trial parameters in shared memory (Closed)
Patch Set: fix tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/field_trial.cc » ('j') | base/metrics/field_trial.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial.h
diff --git a/base/metrics/field_trial.h b/base/metrics/field_trial.h
index 306f0075c6657d04c6e23f95a41e8dce455e37a3..31b89e62d74908bd361c43842ccfb5aef46cada8 100644
--- a/base/metrics/field_trial.h
+++ b/base/metrics/field_trial.h
@@ -225,6 +225,8 @@ class BASE_EXPORT FieldTrial : public RefCounted<FieldTrial> {
friend class RefCounted<FieldTrial>;
+ friend class FieldTrialParamAssociator;
+
// This is the group number of the 'default' group when a choice wasn't forced
// by a call to FieldTrialList::CreateFieldTrial. It is kept private so that
// consumers don't use it by mistake in cases where the group was forced.
@@ -432,6 +434,15 @@ class BASE_EXPORT FieldTrialList {
// metrics, crashes, etc.
static std::string FindFullName(const std::string& trial_name);
+ // Looks in the allocator for |field_trial|'s params via its ref_, and stores
+ // it in |params|.
+ static bool GetParamsFromSharedMemory(
+ FieldTrial* field_trial,
+ std::map<std::string, std::string>* params);
+
+ // Clears all the params in the allocator.
+ static void ClearParamsFromSharedMemoryForTesting();
+
// Returns true if the named trial has been registered.
static bool TrialExists(const std::string& trial_name);
@@ -543,6 +554,7 @@ class BASE_EXPORT FieldTrialList {
// Allow tests to access our innards for testing purposes.
FRIEND_TEST_ALL_PREFIXES(FieldTrialListTest, InstantiateAllocator);
FRIEND_TEST_ALL_PREFIXES(FieldTrialListTest, AddTrialsToAllocator);
+ FRIEND_TEST_ALL_PREFIXES(FieldTrialListTest, AssociateFieldTrialParams);
#if defined(OS_WIN)
// Takes in |handle| that should have been retrieved from the command line and
@@ -596,7 +608,7 @@ class BASE_EXPORT FieldTrialList {
static bool used_without_global_;
// Lock for access to registered_.
- base::Lock lock_;
+ Lock lock_;
RegistrationMap registered_;
std::map<std::string, std::string> seen_states_;
« no previous file with comments | « no previous file | base/metrics/field_trial.cc » ('j') | base/metrics/field_trial.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698