Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: base/metrics/field_trial_param_associator.h

Issue 2463223002: Store field trial parameters in shared memory (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_METRICS_FIELD_TRIAL_PARAM_ASSOCIATOR_H_ 5 #ifndef BASE_METRICS_FIELD_TRIAL_PARAM_ASSOCIATOR_H_
6 #define BASE_METRICS_FIELD_TRIAL_PARAM_ASSOCIATOR_H_ 6 #define BASE_METRICS_FIELD_TRIAL_PARAM_ASSOCIATOR_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 15 matching lines...) Expand all
26 typedef std::map<std::string, std::string> FieldTrialParams; 26 typedef std::map<std::string, std::string> FieldTrialParams;
27 27
28 // Retrieve the singleton. 28 // Retrieve the singleton.
29 static FieldTrialParamAssociator* GetInstance(); 29 static FieldTrialParamAssociator* GetInstance();
30 30
31 // Sets parameters for the given field trial name and group. 31 // Sets parameters for the given field trial name and group.
32 bool AssociateFieldTrialParams(const std::string& trial_name, 32 bool AssociateFieldTrialParams(const std::string& trial_name,
33 const std::string& group_name, 33 const std::string& group_name,
34 const FieldTrialParams& params); 34 const FieldTrialParams& params);
35 35
36 // Gets the parameters for a field trial and its chosen group. 36 // Gets the parameters for a field trial. If the parameters are not in the
37 // mapping, then check the field trial entry in shared memory for the
38 // parameters and cache them here. This version of the API doesn't activate
39 // the trial, which is what we want, since serializing to child processes
40 // shouldn't activate the trial.
37 bool GetFieldTrialParams(const std::string& trial_name, 41 bool GetFieldTrialParams(const std::string& trial_name,
38 FieldTrialParams* params); 42 FieldTrialParams* params);
39 43
44 // Same as above, except doesn't search in FieldTrialList for the group name,
45 // since that can cause a deadlock if calling from FieldTrialList.
46 bool GetFieldTrialParamsWithGroupName(const std::string& trial_name,
47 const std::string& group_name,
48 FieldTrialParams* params);
49
40 // Clears the internal field_trial_params_ mapping. 50 // Clears the internal field_trial_params_ mapping.
41 void ClearAllParamsForTesting(); 51 void ClearAllParamsForTesting();
42 52
43 private: 53 private:
44 friend struct DefaultSingletonTraits<FieldTrialParamAssociator>; 54 friend struct DefaultSingletonTraits<FieldTrialParamAssociator>;
45 55
46 // (field_trial_name, field_trial_group) 56 // (field_trial_name, field_trial_group)
47 typedef std::pair<std::string, std::string> FieldTrialKey; 57 typedef std::pair<std::string, std::string> FieldTrialKey;
48 58
59 // Looks up the field trial entry in shared memory and gets the params from
60 // there.
61 bool GetParamsFromSharedMemory(const std::string& trial_name,
62 const std::string& group_name,
63 FieldTrialParams* params);
64
65 // Sets the parameters for |trial_name| and |group_name|. Caller must lock.
66 bool AssociateParamsWhileLocked(const std::string& trial_name,
67 const std::string& group_name,
68 const FieldTrialParams& params);
69
49 Lock lock_; 70 Lock lock_;
50 std::map<FieldTrialKey, FieldTrialParams> field_trial_params_; 71 std::map<FieldTrialKey, FieldTrialParams> field_trial_params_;
51 72
52 DISALLOW_COPY_AND_ASSIGN(FieldTrialParamAssociator); 73 DISALLOW_COPY_AND_ASSIGN(FieldTrialParamAssociator);
53 }; 74 };
54 75
55 } // namespace base 76 } // namespace base
56 77
57 #endif // BASE_METRICS_FIELD_TRIAL_PARAM_ASSOCIATOR_H_ 78 #endif // BASE_METRICS_FIELD_TRIAL_PARAM_ASSOCIATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698