Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Side by Side Diff: base/metrics/field_trial_param_associator.cc

Issue 2463223002: Store field trial parameters in shared memory (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/metrics/field_trial_param_associator.h" 5 #include "base/metrics/field_trial_param_associator.h"
6 6
7 #include "base/metrics/field_trial.h" 7 #include "base/metrics/field_trial.h"
8 8
9 namespace base { 9 namespace base {
10 10
11 FieldTrialParamAssociator::FieldTrialParamAssociator() {} 11 FieldTrialParamAssociator::FieldTrialParamAssociator() {}
12 FieldTrialParamAssociator::~FieldTrialParamAssociator() {} 12 FieldTrialParamAssociator::~FieldTrialParamAssociator() {}
13 13
14 // static 14 // static
15 FieldTrialParamAssociator* FieldTrialParamAssociator::GetInstance() { 15 FieldTrialParamAssociator* FieldTrialParamAssociator::GetInstance() {
16 return Singleton<FieldTrialParamAssociator, 16 return Singleton<FieldTrialParamAssociator,
17 LeakySingletonTraits<FieldTrialParamAssociator>>::get(); 17 LeakySingletonTraits<FieldTrialParamAssociator>>::get();
18 } 18 }
19 19
20 bool FieldTrialParamAssociator::AssociateFieldTrialParams( 20 bool FieldTrialParamAssociator::AssociateFieldTrialParams(
21 const std::string& trial_name, 21 const std::string& trial_name,
22 const std::string& group_name, 22 const std::string& group_name,
23 const FieldTrialParams& params) { 23 const FieldTrialParams& params) {
24 AutoLock scoped_lock(lock_); 24 AutoLock scoped_lock(lock_);
25 25
26 if (FieldTrialList::IsTrialActive(trial_name)) 26 return AssociateParamsWhileLocked(trial_name, group_name, params);
27 return false;
28
29 const FieldTrialKey key(trial_name, group_name);
30 if (ContainsKey(field_trial_params_, key))
31 return false;
32
33 field_trial_params_[key] = params;
34 return true;
35 } 27 }
36 28
37 bool FieldTrialParamAssociator::GetFieldTrialParams( 29 bool FieldTrialParamAssociator::GetFieldTrialParams(
38 const std::string& trial_name, 30 const std::string& trial_name,
39 FieldTrialParams* params) { 31 FieldTrialParams* params) {
40 AutoLock scoped_lock(lock_); 32 AutoLock scoped_lock(lock_);
41 33
42 const std::string group_name = FieldTrialList::FindFullName(trial_name); 34 const std::string group_name = FieldTrialList::FindFullName(trial_name);
35 return GetFieldTrialParamsWithGroupName(trial_name, group_name, params);
36 }
37
38 bool FieldTrialParamAssociator::GetFieldTrialParamsWithGroupName(
39 const std::string& trial_name,
40 const std::string& group_name,
41 FieldTrialParams* params) {
42 AutoLock scoped_lock(lock_);
43
43 const FieldTrialKey key(trial_name, group_name); 44 const FieldTrialKey key(trial_name, group_name);
44 if (!ContainsKey(field_trial_params_, key)) 45 if (!ContainsKey(field_trial_params_, key))
45 return false; 46 return GetParamsFromSharedMemory(trial_name, group_name, params);
46 47
47 *params = field_trial_params_[key]; 48 *params = field_trial_params_[key];
48 return true; 49 return true;
49 } 50 }
50 51
51 void FieldTrialParamAssociator::ClearAllParamsForTesting() { 52 void FieldTrialParamAssociator::ClearAllParamsForTesting() {
52 AutoLock scoped_lock(lock_); 53 AutoLock scoped_lock(lock_);
53 field_trial_params_.clear(); 54 field_trial_params_.clear();
54 } 55 }
55 56
57 bool FieldTrialParamAssociator::GetParamsFromSharedMemory(
58 const std::string& trial_name,
59 const std::string& group_name,
60 FieldTrialParams* params) {
61 bool result = FieldTrialList::FindParams(trial_name, params);
62 if (result)
63 AssociateParamsWhileLocked(trial_name, group_name, *params);
64 return result;
65 }
66
67 bool FieldTrialParamAssociator::AssociateParamsWhileLocked(
68 const std::string& trial_name,
69 const std::string& group_name,
70 const FieldTrialParams& params) {
71 if (FieldTrialList::IsTrialActive(trial_name))
72 return false;
73
74 const FieldTrialKey key(trial_name, group_name);
75 if (ContainsKey(field_trial_params_, key))
76 return false;
77
78 field_trial_params_[key] = params;
79 return true;
80 }
81
56 } // namespace base 82 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698