Store field trial parameters in shared memory

base/metrics/field_trial_param_associator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/field_trial_param_associator.h"
 
 #include "base/metrics/field_trial.h"
 
 namespace base {
 
@@ skipping 19 matching lines @@
   if (ContainsKey(field_trial_params_, key))
     return false;
 
   field_trial_params_[key] = params;
   return true;
 }
 
 bool FieldTrialParamAssociator::GetFieldTrialParams(
     const std::string& trial_name,
     FieldTrialParams* params) {
+  // We first try looking for the params in field_trial_params_.

[bcwhite, 2016/11/23 21:03:52]

field_trial_params_ isn't accessed in the code so add comment "via
FieldTrialList"... or whatever is actually correct.  Or don't mention that field
at all.

[lawrencewu, 2016/11/23 21:49:20]

Changed to say "via GetFieldTrialParamsWithoutFallback", since it is actually
accessing it from there.

+  // If that is unsuccessful, then we try to look it up in shared memory.

[bcwhite, 2016/11/23 21:03:52]

Lines 43-44 say: if unsuccessful then return

[lawrencewu, 2016/11/23 21:49:20]

I cleared it up a bit to say: "If it's not there, then try to look it up in
shared memory." and moved the comment down so it's more obvious what lines of
code this comment is talking about.

+  FieldTrial* field_trial = FieldTrialList::Find(trial_name);
+  if (!field_trial)
+    return false;
+
+  if (GetFieldTrialParamsWithoutFallback(trial_name, field_trial->group_name(),
+                                         params)) {
+    return true;
+  }
+
+  // TODO(lawrencewu): add the params to field_trial_params_ for next time.
+  return FieldTrialList::GetParamsFromSharedMemory(field_trial, params);
+}
+
+bool FieldTrialParamAssociator::GetFieldTrialParamsWithoutFallback(
+    const std::string& trial_name,
+    const std::string& group_name,
+    FieldTrialParams* params) {
   AutoLock scoped_lock(lock_);
 
-  const std::string group_name = FieldTrialList::FindFullName(trial_name);
   const FieldTrialKey key(trial_name, group_name);
   if (!ContainsKey(field_trial_params_, key))
     return false;
 
   *params = field_trial_params_[key];
   return true;
 }
 
 void FieldTrialParamAssociator::ClearAllParamsForTesting() {
   AutoLock scoped_lock(lock_);
   field_trial_params_.clear();
+  FieldTrialList::ClearParamsFromSharedMemoryForTesting();
+}
+
+void FieldTrialParamAssociator::ClearAllCachedParamsForTesting() {
+  AutoLock scoped_lock(lock_);
+  field_trial_params_.clear();
 }
 
 }  // namespace base