chrome/browser/thumbnails/thumbnail_service.h - Issue 24632002: Implementing chrome://thumbnails page to view URLs in TopSites and cached thumbnails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/thumbnail_service.h

Issue 24632002: Implementing chrome://thumbnails page to view URLs in TopSites and cached thumbnails. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Embedding thumbs via data:image/png;base64,; removing HasPageThumbnail(). Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search/instant_service.cc ('k') | chrome/browser/thumbnails/thumbnail_service_impl.cc » ('j') | chrome/browser/ui/webui/ntp/thumbnail_list_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/thumbnails/thumbnail_service.h

diff --git a/chrome/browser/thumbnails/thumbnail_service.h b/chrome/browser/thumbnails/thumbnail_service.h

index 16a0273837e33aa17894c17d2683b9e941b9d6cd..ac21881774ae7a337a125beefea6c6539ba98b81 100644

--- a/chrome/browser/thumbnails/thumbnail_service.h

+++ b/chrome/browser/thumbnails/thumbnail_service.h

@@ -8,7 +8,8 @@

#include "chrome/common/thumbnail_score.h"

#include "components/browser_context_keyed_service/refcounted_browser_context_keyed_service.h"

#include "ui/gfx/image/image.h"

-#include "url/gurl.h"

+class GURL;

namespace base {

class RefCountedMemory;

@@ -40,7 +41,8 @@ class ThumbnailService : public RefcountedBrowserContextKeyedService {

// Gets a thumbnail for a given page. Returns true iff we have the thumbnail.

// This may be invoked on any thread.

// If an exact thumbnail URL match fails, |prefix_match| specifies whether or

- // not to try harder by matching the query thumbnail URL as URL prefix.

+ // not to try harder by matching the query thumbnail URL as URL prefix (as

+ // defined by UrlIsPrefix()).

// As this method may be invoked on any thread the ref count needs to be

// incremented before this method returns, so this takes a scoped_refptr*.

virtual bool GetPageThumbnail(