Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2463183002: Fix a memory leak in CPDF_SecurityHandler. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix a memory leak in CPDF_SecurityHandler. AES256_CheckPassword() leaks memory on failure. Clean up some nits. BUG=chromium:659468 Committed: https://pdfium.googlesource.com/pdfium/+/a3580f9fb0eb11f7a501a28be953ff948c28ce06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M core/fpdfapi/parser/cpdf_security_handler.cpp View 1 chunk +19 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
4 years, 1 month ago (2016-10-31 19:19:07 UTC) #4
dsinclair
lgtm
4 years, 1 month ago (2016-10-31 19:28:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463183002/1
4 years, 1 month ago (2016-10-31 20:06:25 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:06:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a3580f9fb0eb11f7a501a28be953ff948c28...

Powered by Google App Engine
This is Rietveld 408576698