Android: Prefix target toolchain names with "android_".

Android: Prefix target toolchain names with "android_".

In x64 builds with clang, we also build a 32-bit binary to ship webview
in both 32-bit and 64-bit.  The 32-bit part is built twice, once for
the linux host to be able to run v8's mksnapshot, and once for the
android target for the actual binary.

Before this change, both the host toolchain and the target toolchain
were called "clang_x86", and they clobbered each other.  (In gcc builds,
the target toolchain was called just "x86" while the host still used
clang, so it happened to work there, mostly by accident.)

BUG=660857, 605315
Committed: https://crrev.com/042f129b96ea6e989df1efe0e4a30dcac09f05a7
Cr-Commit-Position: refs/heads/master@{#428783}

[Nico, 2016-10-31 18:16:44]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2016-10-31 18:17:03]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:17:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-31 18:27:48]

Also, I guess gn should diag if two distinct toolchains end up with the same
name?

[commit-bot: I haz the power, 2016-10-31 18:53:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:53:29]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Nico, 2016-10-31 19:19:13]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 19:19:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-10-31 19:54:30]

On 2016/10/31 18:27:48, Nico wrote:
> Also, I guess gn should diag if two distinct toolchains end up with the same
> name?

That seems like a good suggestion; mind filing a bug?

[Dirk Pranke, 2016-10-31 19:54:51]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2016-10-31 19:54:51]

lgtm, but brettw@ will have to have to approve the BUILDCONFIG change as well.

[brettw, 2016-10-31 20:05:30]

lgtm

[commit-bot: I haz the power, 2016-10-31 20:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:12:38]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-10-31 20:14:24]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:15:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:23:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-31 20:27:00]

Description was changed from

==========
Android: Prefix target toolchain names with "android_".

In x64 builds with clang, we also build a 32-bit binary to ship webview
in both 32-bit and 64-bit.  The 32-bit part is built twice, once for
the linux host to be able to run v8's mksnapshot, and once for the
android target for the actual binary.

Before this change, both the host toolchain and the target toolchain
were called "clang_x86", and they clobbered each other.  (In gcc builds,
the target toolchain was called just "x86" while the host still used
clang, so it happened to work there, mostly by accident.)

BUG=660857,605315
==========

to

==========
Android: Prefix target toolchain names with "android_".

In x64 builds with clang, we also build a 32-bit binary to ship webview
in both 32-bit and 64-bit.  The 32-bit part is built twice, once for
the linux host to be able to run v8's mksnapshot, and once for the
android target for the actual binary.

Before this change, both the host toolchain and the target toolchain
were called "clang_x86", and they clobbered each other.  (In gcc builds,
the target toolchain was called just "x86" while the host still used
clang, so it happened to work there, mostly by accident.)

BUG=660857,605315

Committed: https://crrev.com/042f129b96ea6e989df1efe0e4a30dcac09f05a7
Cr-Commit-Position: refs/heads/master@{#428783}
==========

[commit-bot: I haz the power, 2016-10-31 20:27:01]

Patchset 1 (id:??) landed as
https://crrev.com/042f129b96ea6e989df1efe0e4a30dcac09f05a7
Cr-Commit-Position: refs/heads/master@{#428783}

[Nico, 2016-11-01 03:21:30]

On 2016/10/31 19:54:30, Dirk Pranke wrote:
> On 2016/10/31 18:27:48, Nico wrote:
> > Also, I guess gn should diag if two distinct toolchains end up with the same
> > name?
> 
> That seems like a good suggestion; mind filing a bug?

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=661054