components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc - Issue 2463133002: 📰 Make the MORE button more configurable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

Issue 2463133002: 📰 Make the MORE button more configurable (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc ('k') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

index 1d25e4a046004b70ec59d379e87f0888b6735420..18c6bd0a8e04e95d2e658e5ce66df872d00a79e6 100644

--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

@@ -147,7 +147,12 @@ TEST_F(RecentTabSuggestionsProviderTest, ShouldSortByMostRecentlyVisited) {

TEST_F(RecentTabSuggestionsProviderTest, ShouldDeliverCorrectCategoryInfo) {

EXPECT_FALSE(

- provider()->GetCategoryInfo(recent_tabs_category()).has_more_button());

+ provider()->GetCategoryInfo(recent_tabs_category()).has_more_action());

+ EXPECT_FALSE(

+ provider()->GetCategoryInfo(recent_tabs_category()).has_reload_action());

+ EXPECT_FALSE(provider()

+ ->GetCategoryInfo(recent_tabs_category())

+ .has_view_all_action());

}

TEST_F(RecentTabSuggestionsProviderTest, ShouldDismiss) {