Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: components/ntp_snippets/category_info.h

Issue 2463133002: 📰 Make the MORE button more configurable (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/category_info.h
diff --git a/components/ntp_snippets/category_info.h b/components/ntp_snippets/category_info.h
index 5eeb9631d2528e8c5e7f40c8d8ba43767223c52b..a65bbdce3d8b83a4261a99404191731e87e5aebb 100644
--- a/components/ntp_snippets/category_info.h
+++ b/components/ntp_snippets/category_info.h
@@ -25,12 +25,13 @@ class CategoryInfo {
public:
CategoryInfo(const base::string16& title,
ContentSuggestionsCardLayout card_layout,
- bool has_more_button,
+ bool has_more_action,
+ bool has_reload_action,
+ bool has_view_all_action,
bool show_if_empty,
const base::string16& no_suggestions_message);
- CategoryInfo(CategoryInfo&&) = default;
- CategoryInfo& operator=(CategoryInfo&&) = default;
-
+ CategoryInfo(CategoryInfo&&);
+ CategoryInfo& operator=(CategoryInfo&&);
~CategoryInfo();
// Localized title of the category.
@@ -39,12 +40,17 @@ class CategoryInfo {
// Layout of the cards to be used to display suggestions in this category.
ContentSuggestionsCardLayout card_layout() const { return card_layout_; }
- // Whether the category should show a "More" button even if it's not empty
- // (there's always a "More" or "Reload" button if it is empty). The button
- // either triggers a fixed action (like opening a native page) or, if there
- // is no such fixed action, it queries the provider for more suggestions.
- // TODO(treib): Rename this to "always_show_more_button".
- bool has_more_button() const { return has_more_button_; }
+ // Whether the category supports a "More" action, that triggers fetching more
+ // suggestions for the category, while keeping the current ones.
+ bool has_more_action() const { return has_more_action_; }
+
+ // Whether the category supports a "Reload" action, that triggers fetching new
+ // suggestions to replace the current ones.
+ bool has_reload_action() const { return has_reload_action_; }
+
+ // Whether the category supports a "ViewAll" action, that triggers displaying
+ // all the content related to the current categories.
+ bool has_view_all_action() const { return has_view_all_action_; }
// Whether this category should be shown if it offers no suggestions.
bool show_if_empty() const { return show_if_empty_; }
@@ -59,7 +65,13 @@ class CategoryInfo {
private:
base::string16 title_;
ContentSuggestionsCardLayout card_layout_;
- bool has_more_button_;
+
+ // Supported actions for the category.
+ bool has_more_action_;
+ bool has_reload_action_;
+ bool has_view_all_action_;
+
+ // Whether to show the category if a fetch returns no suggestions.
bool show_if_empty_;
base::string16 no_suggestions_message_;
« no previous file with comments | « components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc ('k') | components/ntp_snippets/category_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698