Refactor media::VideoRendererImpl tests to use more human-friendly notation for queueing frames.

Refactor media::VideoRendererImpl tests to use more human-friendly notation for queueing frames.

While the tests are more verbose there is now less magic happening when using helper functions. The end result is a more flexible and understandable test harness, which will be handy when switching to using VideoFrameScheduler.

BUG=110814
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265582

[scherkus (not reviewing), 2014-04-22 01:55:23]

more test clean up to help switch over to the scheduler

somewhat surprisingly, this patch still manages to reduce the total line count
of VideoRendererImpl

[scherkus (not reviewing), 2014-04-22 18:54:54]

xhwang: here is another one for you to look at as acolwell is busy

[xhwang, 2014-04-22 20:52:25]

lgtm % nits

https://codereview.chromium.org/246313002/diff/1/media/filters/video_renderer...
File media/filters/video_renderer_impl_unittest.cc (right):

https://codereview.chromium.org/246313002/diff/1/media/filters/video_renderer...
media/filters/video_renderer_impl_unittest.cc:167: //   nn - Queue a decoder
buffer with timestamp nn * 1000us
1000us == 1ms? http://en.wikipedia.org/wiki/Second#SI_multiples

https://codereview.chromium.org/246313002/diff/1/media/filters/video_renderer...
media/filters/video_renderer_impl_unittest.cc:170: //   eos - Queue an end of
stream decoder buffer
Can you have a high level comment about this? e.g. use a string to represent
frames to be queued. The string has frame tokens delimited by spaces... etc

[scherkus (not reviewing), 2014-04-22 21:58:53]

https://codereview.chromium.org/246313002/diff/1/media/filters/video_renderer...
File media/filters/video_renderer_impl_unittest.cc (right):

https://codereview.chromium.org/246313002/diff/1/media/filters/video_renderer...
media/filters/video_renderer_impl_unittest.cc:167: //   nn - Queue a decoder
buffer with timestamp nn * 1000us
On 2014/04/22 20:52:25, xhwang wrote:
> 1000us == 1ms? http://en.wikipedia.org/wiki/Second#SI_multiples

Yep! Since microseconds are the lowest unit a timestamp is represented in I felt
like using that was less ambiguous

https://codereview.chromium.org/246313002/diff/1/media/filters/video_renderer...
media/filters/video_renderer_impl_unittest.cc:170: //   eos - Queue an end of
stream decoder buffer
On 2014/04/22 20:52:25, xhwang wrote:
> Can you have a high level comment about this? e.g. use a string to represent
> frames to be queued. The string has frame tokens delimited by spaces... etc

Done.

[scherkus (not reviewing), 2014-04-23 03:44:14]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-23 03:44:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/246313002/20001

[commit-bot: I haz the power, 2014-04-23 03:46:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 03:46:52]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_clang_dbg
  tryserver.chromium on linux_chromium_rel

[scherkus (not reviewing), 2014-04-23 04:01:49]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-23 04:02:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/246313002/20001

[commit-bot: I haz the power, 2014-04-23 04:05:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 04:05:38]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_clang_dbg

[scherkus (not reviewing), 2014-04-23 04:08:31]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-23 04:09:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/246313002/20001

[commit-bot: I haz the power, 2014-04-23 08:43:55]

Change committed as 265582