Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 2463083002: Remove default monomorphic check code from functions and stubs that do not need it. (Closed)
Patch Set: address comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stub_code_arm.cc
diff --git a/runtime/vm/stub_code_arm.cc b/runtime/vm/stub_code_arm.cc
index 49dcfab8bc07c0c8689e75fac27b161fbfd103df..6831e9a42a9a1d74316253f2dec75d4501bac51c 100644
--- a/runtime/vm/stub_code_arm.cc
+++ b/runtime/vm/stub_code_arm.cc
@@ -2031,8 +2031,6 @@ void StubCode::GenerateOptimizedIdenticalWithNumberCheckStub(
// CODE_REG: target Code
// R4: arguments descriptor
void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) {
- __ NoMonomorphicCheckedEntry();
-
__ LoadTaggedClassIdMayBeSmi(R0, R0);
// R0: receiver cid as Smi.
__ ldr(R2, FieldAddress(R9, MegamorphicCache::buckets_offset()));
@@ -2088,8 +2086,6 @@ void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) {
// CODE_REG: target Code object
// R4: arguments descriptor
void StubCode::GenerateICCallThroughFunctionStub(Assembler* assembler) {
- __ NoMonomorphicCheckedEntry();
-
Label loop, found, miss;
__ ldr(R4, FieldAddress(R9, ICData::arguments_descriptor_offset()));
__ ldr(R8, FieldAddress(R9, ICData::ic_data_offset()));
@@ -2125,8 +2121,6 @@ void StubCode::GenerateICCallThroughFunctionStub(Assembler* assembler) {
void StubCode::GenerateICCallThroughCodeStub(Assembler* assembler) {
- __ NoMonomorphicCheckedEntry();
-
Label loop, found, miss;
__ ldr(R4, FieldAddress(R9, ICData::arguments_descriptor_offset()));
__ ldr(R8, FieldAddress(R9, ICData::ic_data_offset()));
@@ -2165,8 +2159,6 @@ void StubCode::GenerateICCallThroughCodeStub(Assembler* assembler) {
// R0: receiver
// R9: UnlinkedCall
void StubCode::GenerateUnlinkedCallStub(Assembler* assembler) {
- __ NoMonomorphicCheckedEntry();
-
__ EnterStubFrame();
__ Push(R0); // Preserve receiver.
@@ -2193,10 +2185,7 @@ void StubCode::GenerateUnlinkedCallStub(Assembler* assembler) {
// Passed to target:
// CODE_REG: target Code object
void StubCode::GenerateSingleTargetCallStub(Assembler* assembler) {
- __ NoMonomorphicCheckedEntry();
-
Label miss;
-
__ LoadClassIdMayBeSmi(R1, R0);
__ ldrh(R2, FieldAddress(R9, SingleTargetCache::lower_limit_offset()));
__ ldrh(R3, FieldAddress(R9, SingleTargetCache::upper_limit_offset()));

Powered by Google App Engine
This is Rietveld 408576698