Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: runtime/vm/megamorphic_cache_table.cc

Issue 2463083002: Remove default monomorphic check code from functions and stubs that do not need it. (Closed)
Patch Set: address comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/megamorphic_cache_table.cc
diff --git a/runtime/vm/megamorphic_cache_table.cc b/runtime/vm/megamorphic_cache_table.cc
index e3d34dd01c5ad7b318116172c60520c466663137..8a4e6af25d24b9245343295eaab925c44943a6bc 100644
--- a/runtime/vm/megamorphic_cache_table.cc
+++ b/runtime/vm/megamorphic_cache_table.cc
@@ -65,7 +65,7 @@ void MegamorphicCacheTable::InitMissHandler(Isolate* isolate) {
const Function& function =
Function::Handle(Function::New(Symbols::MegamorphicMiss(),
RawFunction::kRegularFunction,
- false, // Not static.
+ true, // Static, but called as a method.
false, // Not const.
false, // Not abstract.
false, // Not external.
@@ -75,7 +75,7 @@ void MegamorphicCacheTable::InitMissHandler(Isolate* isolate) {
function.set_result_type(Type::Handle(Type::DynamicType()));
function.set_is_debuggable(false);
function.set_is_visible(false);
- function.AttachCode(code);
+ function.AttachCode(code); // Has a single entry point, as a static function.
// For inclusion in Snapshot::kAppWithJIT.
function.set_unoptimized_code(code);
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/object.h » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698