Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: runtime/vm/stub_code_arm64.cc

Issue 2463083002: Remove default monomorphic check code from functions and stubs that do not need it. (Closed)
Patch Set: address comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 2055 matching lines...) Expand 10 before | Expand all | Expand 10 after
2066 } 2066 }
2067 2067
2068 2068
2069 // Called from megamorphic calls. 2069 // Called from megamorphic calls.
2070 // R0: receiver 2070 // R0: receiver
2071 // R5: MegamorphicCache (preserved) 2071 // R5: MegamorphicCache (preserved)
2072 // Passed to target: 2072 // Passed to target:
2073 // CODE_REG: target Code 2073 // CODE_REG: target Code
2074 // R4: arguments descriptor 2074 // R4: arguments descriptor
2075 void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) { 2075 void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) {
2076 __ NoMonomorphicCheckedEntry();
2077
2078 // Jump if receiver is a smi. 2076 // Jump if receiver is a smi.
2079 Label smi_case; 2077 Label smi_case;
2080 __ TestImmediate(R0, kSmiTagMask); 2078 __ TestImmediate(R0, kSmiTagMask);
2081 __ b(&smi_case, EQ); 2079 __ b(&smi_case, EQ);
2082 2080
2083 // Loads the cid of the object. 2081 // Loads the cid of the object.
2084 __ LoadClassId(R0, R0); 2082 __ LoadClassId(R0, R0);
2085 2083
2086 Label cid_loaded; 2084 Label cid_loaded;
2087 __ Bind(&cid_loaded); 2085 __ Bind(&cid_loaded);
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
2141 } 2139 }
2142 2140
2143 2141
2144 // Called from switchable IC calls. 2142 // Called from switchable IC calls.
2145 // R0: receiver 2143 // R0: receiver
2146 // R5: ICData (preserved) 2144 // R5: ICData (preserved)
2147 // Passed to target: 2145 // Passed to target:
2148 // CODE_REG: target Code object 2146 // CODE_REG: target Code object
2149 // R4: arguments descriptor 2147 // R4: arguments descriptor
2150 void StubCode::GenerateICCallThroughFunctionStub(Assembler* assembler) { 2148 void StubCode::GenerateICCallThroughFunctionStub(Assembler* assembler) {
2151 __ NoMonomorphicCheckedEntry();
2152
2153 Label loop, found, miss; 2149 Label loop, found, miss;
2154 __ ldr(R4, FieldAddress(R5, ICData::arguments_descriptor_offset())); 2150 __ ldr(R4, FieldAddress(R5, ICData::arguments_descriptor_offset()));
2155 __ ldr(R8, FieldAddress(R5, ICData::ic_data_offset())); 2151 __ ldr(R8, FieldAddress(R5, ICData::ic_data_offset()));
2156 __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag); 2152 __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag);
2157 // R8: first IC entry 2153 // R8: first IC entry
2158 __ LoadTaggedClassIdMayBeSmi(R1, R0); 2154 __ LoadTaggedClassIdMayBeSmi(R1, R0);
2159 // R1: receiver cid as Smi 2155 // R1: receiver cid as Smi
2160 2156
2161 __ Bind(&loop); 2157 __ Bind(&loop);
2162 __ ldr(R2, Address(R8, 0)); 2158 __ ldr(R2, Address(R8, 0));
(...skipping 15 matching lines...) Expand all
2178 2174
2179 __ Bind(&miss); 2175 __ Bind(&miss);
2180 __ LoadIsolate(R2); 2176 __ LoadIsolate(R2);
2181 __ ldr(CODE_REG, Address(R2, Isolate::ic_miss_code_offset())); 2177 __ ldr(CODE_REG, Address(R2, Isolate::ic_miss_code_offset()));
2182 __ ldr(R1, FieldAddress(CODE_REG, Code::entry_point_offset())); 2178 __ ldr(R1, FieldAddress(CODE_REG, Code::entry_point_offset()));
2183 __ br(R1); 2179 __ br(R1);
2184 } 2180 }
2185 2181
2186 2182
2187 void StubCode::GenerateICCallThroughCodeStub(Assembler* assembler) { 2183 void StubCode::GenerateICCallThroughCodeStub(Assembler* assembler) {
2188 __ NoMonomorphicCheckedEntry();
2189
2190 Label loop, found, miss; 2184 Label loop, found, miss;
2191 __ ldr(R4, FieldAddress(R5, ICData::arguments_descriptor_offset())); 2185 __ ldr(R4, FieldAddress(R5, ICData::arguments_descriptor_offset()));
2192 __ ldr(R8, FieldAddress(R5, ICData::ic_data_offset())); 2186 __ ldr(R8, FieldAddress(R5, ICData::ic_data_offset()));
2193 __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag); 2187 __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag);
2194 // R8: first IC entry 2188 // R8: first IC entry
2195 __ LoadTaggedClassIdMayBeSmi(R1, R0); 2189 __ LoadTaggedClassIdMayBeSmi(R1, R0);
2196 // R1: receiver cid as Smi 2190 // R1: receiver cid as Smi
2197 2191
2198 __ Bind(&loop); 2192 __ Bind(&loop);
2199 __ ldr(R2, Address(R8, 0)); 2193 __ ldr(R2, Address(R8, 0));
(...skipping 18 matching lines...) Expand all
2218 __ ldr(CODE_REG, Address(R2, Isolate::ic_miss_code_offset())); 2212 __ ldr(CODE_REG, Address(R2, Isolate::ic_miss_code_offset()));
2219 __ ldr(R1, FieldAddress(CODE_REG, Code::entry_point_offset())); 2213 __ ldr(R1, FieldAddress(CODE_REG, Code::entry_point_offset()));
2220 __ br(R1); 2214 __ br(R1);
2221 } 2215 }
2222 2216
2223 2217
2224 // Called from switchable IC calls. 2218 // Called from switchable IC calls.
2225 // R0: receiver 2219 // R0: receiver
2226 // R5: SingleTargetCache 2220 // R5: SingleTargetCache
2227 void StubCode::GenerateUnlinkedCallStub(Assembler* assembler) { 2221 void StubCode::GenerateUnlinkedCallStub(Assembler* assembler) {
2228 __ NoMonomorphicCheckedEntry();
2229
2230 __ EnterStubFrame(); 2222 __ EnterStubFrame();
2231 __ Push(R0); // Preserve receiver. 2223 __ Push(R0); // Preserve receiver.
2232 2224
2233 __ Push(ZR); // Result slot. 2225 __ Push(ZR); // Result slot.
2234 __ Push(R0); // Arg0: Receiver 2226 __ Push(R0); // Arg0: Receiver
2235 __ Push(R5); // Arg1: UnlinkedCall 2227 __ Push(R5); // Arg1: UnlinkedCall
2236 __ CallRuntime(kUnlinkedCallRuntimeEntry, 2); 2228 __ CallRuntime(kUnlinkedCallRuntimeEntry, 2);
2237 __ Drop(2); 2229 __ Drop(2);
2238 __ Pop(R5); // result = IC 2230 __ Pop(R5); // result = IC
2239 2231
2240 __ Pop(R0); // Restore receiver. 2232 __ Pop(R0); // Restore receiver.
2241 __ LeaveStubFrame(); 2233 __ LeaveStubFrame();
2242 2234
2243 __ ldr(CODE_REG, Address(THR, Thread::ic_lookup_through_code_stub_offset())); 2235 __ ldr(CODE_REG, Address(THR, Thread::ic_lookup_through_code_stub_offset()));
2244 __ ldr(R1, FieldAddress(CODE_REG, Code::checked_entry_point_offset())); 2236 __ ldr(R1, FieldAddress(CODE_REG, Code::checked_entry_point_offset()));
2245 __ br(R1); 2237 __ br(R1);
2246 } 2238 }
2247 2239
2248 2240
2249 // Called from switchable IC calls. 2241 // Called from switchable IC calls.
2250 // R0: receiver 2242 // R0: receiver
2251 // R5: SingleTargetCache 2243 // R5: SingleTargetCache
2252 // Passed to target: 2244 // Passed to target:
2253 // CODE_REG: target Code object 2245 // CODE_REG: target Code object
2254 void StubCode::GenerateSingleTargetCallStub(Assembler* assembler) { 2246 void StubCode::GenerateSingleTargetCallStub(Assembler* assembler) {
2255 __ NoMonomorphicCheckedEntry();
2256
2257 Label miss; 2247 Label miss;
2258
2259 __ LoadClassIdMayBeSmi(R1, R0); 2248 __ LoadClassIdMayBeSmi(R1, R0);
2260 __ ldr(R2, FieldAddress(R5, SingleTargetCache::lower_limit_offset()), 2249 __ ldr(R2, FieldAddress(R5, SingleTargetCache::lower_limit_offset()),
2261 kUnsignedWord); 2250 kUnsignedWord);
2262 __ ldr(R3, FieldAddress(R5, SingleTargetCache::upper_limit_offset()), 2251 __ ldr(R3, FieldAddress(R5, SingleTargetCache::upper_limit_offset()),
2263 kUnsignedWord); 2252 kUnsignedWord);
2264 2253
2265 __ cmp(R1, Operand(R2)); 2254 __ cmp(R1, Operand(R2));
2266 __ b(&miss, LT); 2255 __ b(&miss, LT);
2267 __ cmp(R1, Operand(R3)); 2256 __ cmp(R1, Operand(R3));
2268 __ b(&miss, GT); 2257 __ b(&miss, GT);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
2312 } 2301 }
2313 2302
2314 2303
2315 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) { 2304 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) {
2316 __ brk(0); 2305 __ brk(0);
2317 } 2306 }
2318 2307
2319 } // namespace dart 2308 } // namespace dart
2320 2309
2321 #endif // defined TARGET_ARCH_ARM64 2310 #endif // defined TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698