Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: runtime/vm/stub_code_arm.cc

Issue 2463083002: Remove default monomorphic check code from functions and stubs that do not need it. (Closed)
Patch Set: address comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 2013 matching lines...) Expand 10 before | Expand all | Expand 10 after
2024 } 2024 }
2025 2025
2026 2026
2027 // Called from megamorphic calls. 2027 // Called from megamorphic calls.
2028 // R0: receiver 2028 // R0: receiver
2029 // R9: MegamorphicCache (preserved) 2029 // R9: MegamorphicCache (preserved)
2030 // Passed to target: 2030 // Passed to target:
2031 // CODE_REG: target Code 2031 // CODE_REG: target Code
2032 // R4: arguments descriptor 2032 // R4: arguments descriptor
2033 void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) { 2033 void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) {
2034 __ NoMonomorphicCheckedEntry();
2035
2036 __ LoadTaggedClassIdMayBeSmi(R0, R0); 2034 __ LoadTaggedClassIdMayBeSmi(R0, R0);
2037 // R0: receiver cid as Smi. 2035 // R0: receiver cid as Smi.
2038 __ ldr(R2, FieldAddress(R9, MegamorphicCache::buckets_offset())); 2036 __ ldr(R2, FieldAddress(R9, MegamorphicCache::buckets_offset()));
2039 __ ldr(R1, FieldAddress(R9, MegamorphicCache::mask_offset())); 2037 __ ldr(R1, FieldAddress(R9, MegamorphicCache::mask_offset()));
2040 // R2: cache buckets array. 2038 // R2: cache buckets array.
2041 // R1: mask. 2039 // R1: mask.
2042 2040
2043 // Compute the table index. 2041 // Compute the table index.
2044 ASSERT(MegamorphicCache::kSpreadFactor == 7); 2042 ASSERT(MegamorphicCache::kSpreadFactor == 7);
2045 // Use reverse substract to multiply with 7 == 8 - 1. 2043 // Use reverse substract to multiply with 7 == 8 - 1.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
2081 } 2079 }
2082 2080
2083 2081
2084 // Called from switchable IC calls. 2082 // Called from switchable IC calls.
2085 // R0: receiver 2083 // R0: receiver
2086 // R9: ICData (preserved) 2084 // R9: ICData (preserved)
2087 // Passed to target: 2085 // Passed to target:
2088 // CODE_REG: target Code object 2086 // CODE_REG: target Code object
2089 // R4: arguments descriptor 2087 // R4: arguments descriptor
2090 void StubCode::GenerateICCallThroughFunctionStub(Assembler* assembler) { 2088 void StubCode::GenerateICCallThroughFunctionStub(Assembler* assembler) {
2091 __ NoMonomorphicCheckedEntry();
2092
2093 Label loop, found, miss; 2089 Label loop, found, miss;
2094 __ ldr(R4, FieldAddress(R9, ICData::arguments_descriptor_offset())); 2090 __ ldr(R4, FieldAddress(R9, ICData::arguments_descriptor_offset()));
2095 __ ldr(R8, FieldAddress(R9, ICData::ic_data_offset())); 2091 __ ldr(R8, FieldAddress(R9, ICData::ic_data_offset()));
2096 __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag); 2092 __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag);
2097 // R8: first IC entry 2093 // R8: first IC entry
2098 __ LoadTaggedClassIdMayBeSmi(R1, R0); 2094 __ LoadTaggedClassIdMayBeSmi(R1, R0);
2099 // R1: receiver cid as Smi 2095 // R1: receiver cid as Smi
2100 2096
2101 __ Bind(&loop); 2097 __ Bind(&loop);
2102 __ ldr(R2, Address(R8, 0)); 2098 __ ldr(R2, Address(R8, 0));
(...skipping 15 matching lines...) Expand all
2118 2114
2119 __ Bind(&miss); 2115 __ Bind(&miss);
2120 __ LoadIsolate(R2); 2116 __ LoadIsolate(R2);
2121 __ ldr(CODE_REG, Address(R2, Isolate::ic_miss_code_offset())); 2117 __ ldr(CODE_REG, Address(R2, Isolate::ic_miss_code_offset()));
2122 __ ldr(R1, FieldAddress(CODE_REG, Code::entry_point_offset())); 2118 __ ldr(R1, FieldAddress(CODE_REG, Code::entry_point_offset()));
2123 __ bx(R1); 2119 __ bx(R1);
2124 } 2120 }
2125 2121
2126 2122
2127 void StubCode::GenerateICCallThroughCodeStub(Assembler* assembler) { 2123 void StubCode::GenerateICCallThroughCodeStub(Assembler* assembler) {
2128 __ NoMonomorphicCheckedEntry();
2129
2130 Label loop, found, miss; 2124 Label loop, found, miss;
2131 __ ldr(R4, FieldAddress(R9, ICData::arguments_descriptor_offset())); 2125 __ ldr(R4, FieldAddress(R9, ICData::arguments_descriptor_offset()));
2132 __ ldr(R8, FieldAddress(R9, ICData::ic_data_offset())); 2126 __ ldr(R8, FieldAddress(R9, ICData::ic_data_offset()));
2133 __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag); 2127 __ AddImmediate(R8, R8, Array::data_offset() - kHeapObjectTag);
2134 // R8: first IC entry 2128 // R8: first IC entry
2135 __ LoadTaggedClassIdMayBeSmi(R1, R0); 2129 __ LoadTaggedClassIdMayBeSmi(R1, R0);
2136 // R1: receiver cid as Smi 2130 // R1: receiver cid as Smi
2137 2131
2138 __ Bind(&loop); 2132 __ Bind(&loop);
2139 __ ldr(R2, Address(R8, 0)); 2133 __ ldr(R2, Address(R8, 0));
(...skipping 18 matching lines...) Expand all
2158 __ ldr(CODE_REG, Address(R2, Isolate::ic_miss_code_offset())); 2152 __ ldr(CODE_REG, Address(R2, Isolate::ic_miss_code_offset()));
2159 __ ldr(R1, FieldAddress(CODE_REG, Code::entry_point_offset())); 2153 __ ldr(R1, FieldAddress(CODE_REG, Code::entry_point_offset()));
2160 __ bx(R1); 2154 __ bx(R1);
2161 } 2155 }
2162 2156
2163 2157
2164 // Called from switchable IC calls. 2158 // Called from switchable IC calls.
2165 // R0: receiver 2159 // R0: receiver
2166 // R9: UnlinkedCall 2160 // R9: UnlinkedCall
2167 void StubCode::GenerateUnlinkedCallStub(Assembler* assembler) { 2161 void StubCode::GenerateUnlinkedCallStub(Assembler* assembler) {
2168 __ NoMonomorphicCheckedEntry();
2169
2170 __ EnterStubFrame(); 2162 __ EnterStubFrame();
2171 __ Push(R0); // Preserve receiver. 2163 __ Push(R0); // Preserve receiver.
2172 2164
2173 __ LoadImmediate(IP, 0); 2165 __ LoadImmediate(IP, 0);
2174 __ Push(IP); // Result slot 2166 __ Push(IP); // Result slot
2175 __ Push(R0); // Arg0: Receiver 2167 __ Push(R0); // Arg0: Receiver
2176 __ Push(R9); // Arg1: UnlinkedCall 2168 __ Push(R9); // Arg1: UnlinkedCall
2177 __ CallRuntime(kUnlinkedCallRuntimeEntry, 2); 2169 __ CallRuntime(kUnlinkedCallRuntimeEntry, 2);
2178 __ Drop(2); 2170 __ Drop(2);
2179 __ Pop(R9); // result = IC 2171 __ Pop(R9); // result = IC
2180 2172
2181 __ Pop(R0); // Restore receiver. 2173 __ Pop(R0); // Restore receiver.
2182 __ LeaveStubFrame(); 2174 __ LeaveStubFrame();
2183 2175
2184 __ ldr(CODE_REG, Address(THR, Thread::ic_lookup_through_code_stub_offset())); 2176 __ ldr(CODE_REG, Address(THR, Thread::ic_lookup_through_code_stub_offset()));
2185 __ ldr(R1, FieldAddress(CODE_REG, Code::checked_entry_point_offset())); 2177 __ ldr(R1, FieldAddress(CODE_REG, Code::checked_entry_point_offset()));
2186 __ bx(R1); 2178 __ bx(R1);
2187 } 2179 }
2188 2180
2189 2181
2190 // Called from switchable IC calls. 2182 // Called from switchable IC calls.
2191 // R0: receiver 2183 // R0: receiver
2192 // R9: SingleTargetCache 2184 // R9: SingleTargetCache
2193 // Passed to target: 2185 // Passed to target:
2194 // CODE_REG: target Code object 2186 // CODE_REG: target Code object
2195 void StubCode::GenerateSingleTargetCallStub(Assembler* assembler) { 2187 void StubCode::GenerateSingleTargetCallStub(Assembler* assembler) {
2196 __ NoMonomorphicCheckedEntry();
2197
2198 Label miss; 2188 Label miss;
2199
2200 __ LoadClassIdMayBeSmi(R1, R0); 2189 __ LoadClassIdMayBeSmi(R1, R0);
2201 __ ldrh(R2, FieldAddress(R9, SingleTargetCache::lower_limit_offset())); 2190 __ ldrh(R2, FieldAddress(R9, SingleTargetCache::lower_limit_offset()));
2202 __ ldrh(R3, FieldAddress(R9, SingleTargetCache::upper_limit_offset())); 2191 __ ldrh(R3, FieldAddress(R9, SingleTargetCache::upper_limit_offset()));
2203 2192
2204 __ cmp(R1, Operand(R2)); 2193 __ cmp(R1, Operand(R2));
2205 __ b(&miss, LT); 2194 __ b(&miss, LT);
2206 __ cmp(R1, Operand(R3)); 2195 __ cmp(R1, Operand(R3));
2207 __ b(&miss, GT); 2196 __ b(&miss, GT);
2208 2197
2209 __ ldr(R1, FieldAddress(R9, SingleTargetCache::entry_point_offset())); 2198 __ ldr(R1, FieldAddress(R9, SingleTargetCache::entry_point_offset()));
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
2253 } 2242 }
2254 2243
2255 2244
2256 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) { 2245 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) {
2257 __ bkpt(0); 2246 __ bkpt(0);
2258 } 2247 }
2259 2248
2260 } // namespace dart 2249 } // namespace dart
2261 2250
2262 #endif // defined TARGET_ARCH_ARM 2251 #endif // defined TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698