Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2463083002: Remove default monomorphic check code from functions and stubs that do not need it. (Closed)
Patch Set: address comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 1018
1019 // Input parameters: 1019 // Input parameters:
1020 // LR: return address. 1020 // LR: return address.
1021 // SP: address of last argument. 1021 // SP: address of last argument.
1022 // FP: caller's frame pointer. 1022 // FP: caller's frame pointer.
1023 // PP: caller's pool pointer. 1023 // PP: caller's pool pointer.
1024 // R9: ic-data. 1024 // R9: ic-data.
1025 // R4: arguments descriptor array. 1025 // R4: arguments descriptor array.
1026 void FlowGraphCompiler::CompileGraph() { 1026 void FlowGraphCompiler::CompileGraph() {
1027 InitCompiler(); 1027 InitCompiler();
1028 const Function& function = parsed_function().function();
1029
1030 #ifdef DART_PRECOMPILER
1031 if (function.IsDynamicFunction()) {
1032 __ MonomorphicCheckedEntry();
1033 }
1034 #endif // DART_PRECOMPILER
1028 1035
1029 if (TryIntrinsify()) { 1036 if (TryIntrinsify()) {
1030 // Skip regular code generation. 1037 // Skip regular code generation.
1031 return; 1038 return;
1032 } 1039 }
1033 1040
1034 EmitFrameEntry(); 1041 EmitFrameEntry();
1035 ASSERT(assembler()->constant_pool_allowed()); 1042 ASSERT(assembler()->constant_pool_allowed());
1036 1043
1037 const Function& function = parsed_function().function();
1038
1039 const int num_fixed_params = function.num_fixed_parameters(); 1044 const int num_fixed_params = function.num_fixed_parameters();
1040 const int num_copied_params = parsed_function().num_copied_params(); 1045 const int num_copied_params = parsed_function().num_copied_params();
1041 const int num_locals = parsed_function().num_stack_locals(); 1046 const int num_locals = parsed_function().num_stack_locals();
1042 1047
1043 // We check the number of passed arguments when we have to copy them due to 1048 // We check the number of passed arguments when we have to copy them due to
1044 // the presence of optional parameters. 1049 // the presence of optional parameters.
1045 // No such checking code is generated if only fixed parameters are declared, 1050 // No such checking code is generated if only fixed parameters are declared,
1046 // unless we are in debug mode or unless we are compiling a closure. 1051 // unless we are in debug mode or unless we are compiling a closure.
1047 if (num_copied_params == 0) { 1052 if (num_copied_params == 0) {
1048 const bool check_arguments = 1053 const bool check_arguments =
(...skipping 921 matching lines...) Expand 10 before | Expand all | Expand 10 after
1970 DRegister dreg = EvenDRegisterOf(reg); 1975 DRegister dreg = EvenDRegisterOf(reg);
1971 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1976 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1972 } 1977 }
1973 1978
1974 1979
1975 #undef __ 1980 #undef __
1976 1981
1977 } // namespace dart 1982 } // namespace dart
1978 1983
1979 #endif // defined TARGET_ARCH_ARM 1984 #endif // defined TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698